Skip to content

Remove extra test for Project Euler 044 #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crhallberg wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −10
Open

Remove extra test for Project Euler 044 #1864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85780e0
test: remove unnecessary and slow second check
crhallberg Dec 4, 2025
334cab4
feat(euler44): look ahead checking saves iterations
crhallberg Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Project-Euler/Problem044.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,17 @@ function problem44(k) {

for (let j = k - 1; j > 0; j--) {
const m = (j * (3 * j - 1)) / 2 // calculate all Pj < Pk
if (isPentagonal(n - m) && isPentagonal(n + m)) {
// Check sum and difference
return n - m // return D
// Check forward, checking n - m doubles work from previous iterations
const sum = n + m
if (isPentagonal(sum)) {
// Check sum - m = n
if (isPentagonal(sum + m)) {
return n // return D
}
// Check sum - n = m
if (isPentagonal(sum + n)) {
return m // return D
}
}
}
}
Expand Down
11 changes: 4 additions & 7 deletions Project-Euler/test/Problem044.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
import { problem44 } from '../Problem044.js'

describe('checking nth prime number', () => {
describe('Project Euler 044 - Pentagon numbers', () => {
test('should be invalid input if number is negative', () => {
expect(() => problem44(-3)).toThrowError('Invalid Input')
})

test('should be invalid input if number is 0', () => {
expect(() => problem44(0)).toThrowError('Invalid Input')
})
// Project Euler Condition Check
test('if the number is greater or equal to 1', () => {

test('solves the problem', () => {
expect(problem44(1)).toBe(5482660)
})
// Project Euler Second Value for Condition Check
test('if the number is greater or equal to 2167', () => {
expect(problem44(2167)).toBe(8476206790)
})
})