Skip to content

Fixed flake8 failed test in select and pulled functions out of basic in genetic_algorithm, Fixes: #7971 #8043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasWaite03 wants to merge 1 commit into from
Closed

Fixed flake8 failed test in select and pulled functions out of basic in genetic_algorithm, Fixes: #7971 #8043

ThomasWaite03 wants to merge 1 commit into from

Conversation

@ThomasWaite03
Copy link

@ThomasWaite03 ThomasWaite03 commented Dec 22, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Dec 22, 2022
@ThomasWaite03 ThomasWaite03 changed the title Fixed flake8 failed test in select and pulled functions out of basic in genetic_algorithm, Fixes: #{$7971} Fixed flake8 failed test in select and pulled functions out of basic in genetic_algorithm, Fixes: #7971 Dec 22, 2022
@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Jan 2, 2023

@ThomasWaite03 FYI if you put the "Fixes: ..." in your comment rather than the title of the PR, then GitHub will automatically link it to the original issue

@tianyizheng02
Copy link
Contributor

tianyizheng02 commented Jul 31, 2023

Closing this PR because #7971 was fixed by #8606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH approved these changes

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThomasWaite03 @tianyizheng02 @CaedenPH