Skip to content

The CI is now able to produce valid macOS Ventura bundles #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umbynos merged 13 commits into from
Nov 29, 2022
Merged

The CI is now able to produce valid macOS Ventura bundles #740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c14358d
rename release workflow
umbynos Nov 3, 2022
54e8769
bump macos runner to macos-12
umbynos Nov 3, 2022
424c3ab
bump ubuntu runner to ubuntu 20.04
umbynos Nov 9, 2022
f17625c
add project name env var, even in the `bundle_id`
umbynos Nov 29, 2022
122965f
rework a bit notarization step
umbynos Nov 3, 2022
f75fa66
move the bundle generation to a dedicated step:
umbynos Nov 7, 2022
ce537c4
use the zip notarized file coming from gon, this requires changes in …
umbynos Nov 18, 2022
e4daf05
use this fork (https://github.com/darkvertex/gon/tree/deep_sign_suppo…
umbynos Nov 7, 2022
49da25a
test (move the config.ini) to see if notarization works
umbynos Nov 8, 2022
9edeb21
fix zip archive being included in the installer
umbynos Nov 8, 2022
f6106d7
github is deprecating `set-output commands`
umbynos Nov 9, 2022
9fb7d8e
forgot "$", special encoding is not needed anymore after 62f7d9d25508…
umbynos Nov 11, 2022
545ae5a
fix `unable-to-process-file-command-output-successfully`
umbynos Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check-certificates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
if: >
(github.event_name != 'pull_request' && github.repository == 'arduino/arduino-create-agent') ||
(github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'arduino/arduino-create-agent')
runs-on: ubuntu-18.04
runs-on: ubuntu-20.04

strategy:
fail-fast: false
Expand Down Expand Up @@ -109,7 +109,7 @@ jobs:
echo "Certificate expiration date: $EXPIRATION_DATE"
echo "Days remaining before expiration: $DAYS_BEFORE_EXPIRATION"

echo "::set-output name=days::$DAYS_BEFORE_EXPIRATION"
echo "days=$DAYS_BEFORE_EXPIRATION" >> $GITHUB_OUTPUT

- name: Check if expiration notification period has been reached
id: check-expiration
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-go-dependencies-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
RESULT="false"
fi

echo "::set-output name=result::$RESULT"
echo "result=$RESULT" >> $GITHUB_OUTPUT

check-cache:
needs: run-determination
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-license.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
RESULT="false"
fi

echo "::set-output name=result::$RESULT"
echo "result=$RESULT" >> $GITHUB_OUTPUT

check-license:
needs: run-determination
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-go-tester-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
RESULT="false"
fi

echo "::set-output name=result::$RESULT"
echo "result=$RESULT" >> $GITHUB_OUTPUT

#this job is heavily customized because the build is quite a bit different from other tooling team projects
build:
Expand All @@ -64,7 +64,7 @@ jobs:
#use the strategy instead because we still use the native build
strategy:
matrix:
os: [ubuntu-18.04, windows-2019, macos-11]
os: [ubuntu-20.04, windows-2019, macos-12]
arch: [-amd64]
include:
- os: windows-2019
Expand Down
Loading