ci: add golangci-lint job #142
Merged
+64
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lint job to CI workflow using golangci-lint-action v7 with golangci-lint v2.1.6 - Create .golangci.yaml config with standard linters (govet, errcheck, staticcheck, unused, ineffassign, misspell, revive) and goimports formatter - Fix lint issues: - Add package comment to logger.go - Check error return values for Close() calls - Rename unused function parameters to _ - Update Go version to 1.24 to match go.mod
- Move linters-settings to linters.settings (v2 schema change) - Add comment to exported Close method
deansheather
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a linter job to CI, following the pattern used in coder/coder.
Changes
CI Workflow (
.github/workflows/ci.yaml)lintjob that runsgolangci-lintusing the officialgolangci/golangci-lint-action@v7golangci-lint v2.1.6(latest stable v2 release)~1.24to matchgo.modLinter Configuration (
.golangci.yaml)New config file with:
Code Fixes
Fixed lint issues found by the new linter:
initNamespace(), wrapClose()to handle errorClose()to handle error, rename unused parameters to_Close()to handle error, rename unusedargsparameter to_