Skip to content

🤖 fix: use regional settings for build date display #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibetitsmike wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −14
Open

🤖 fix: use regional settings for build date display #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions src/browser/components/TitleBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,26 +34,17 @@ function hasBuildInfo(value: unknown): value is VersionMetadata {
return typeof candidate.buildTime === "string";
}

// undefined locale = use browser's default, respecting regional settings
const USER_LOCALE = undefined;

function formatLocalDate(isoDate: string): string {
const date = new Date(isoDate);
return date.toLocaleDateString(undefined, {
year: "numeric",
month: "2-digit",
day: "2-digit",
});
return date.toLocaleDateString(USER_LOCALE, { dateStyle: "short" });
}

function formatExtendedTimestamp(isoDate: string): string {
const date = new Date(isoDate);
return date.toLocaleString("en-US", {
month: "long",
day: "numeric",
year: "numeric",
hour: "2-digit",
minute: "2-digit",
second: "2-digit",
timeZoneName: "short",
});
return date.toLocaleString(USER_LOCALE, { dateStyle: "medium", timeStyle: "short" });
}

function parseBuildInfo(version: unknown) {
Expand Down
Loading