feat(git-clone): add clone_args variable for custom git clone arguments #594
+188
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to pass additional arguments to the git clone command via a new `clone_args` variable. This enables use cases like using a local mirror with `--reference` to speed up cloning large repositories. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace nested conditionals with a single git clone call that builds arguments dynamically using POSIX-compatible `set --` and `$@`. This reduces code duplication and makes the script easier to maintain. Also switched shebang from bash to sh for better portability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add tests covering all combinations of depth, branch_name, and clone_args to ensure the refactored run.sh properly handles all argument scenarios. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Refactor run.sh to use bash arrays instead of nested conditionals - Replace 4 separate git clone command variations with a single call - Update tests to use bitnami/git image (has both bash and git) - Use debian:stable-slim for "no git" test (has bash without git) - Update test assertions to use toContain for path flexibility This simplifies the script while maintaining all functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
6fa37b7 to
e89431f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
clone_argsvariable to the git-clone module that allows users to pass additional arguments to the git clone command.Use case: We have a large monorepo and embedding a local git mirror in our custom AMI allows us to use
--reference /path/to/mirrorto dramatically improve clone times. This variable enables that workflow without requiring a fork of the module.Type of Change
Module Information
Path:
registry/coder/modules/git-cloneNew version:
v1.3.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
None
🤖 Generated with Claude Code