Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 12, 2024

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (120d514) to head (de95ac0).
Report is 275 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1062      +/-   ##
==========================================
+ Coverage   97.33%   97.50%   +0.16%     
==========================================
  Files          42       55      +13     
  Lines        2104     2446     +342     
==========================================
+ Hits         2048     2385     +337     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.50% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W
Copy link
Member Author

Lee-W commented Apr 12, 2024

I resolve the commit in #1052 incorrectly 🤦‍♂️ I'll merge this one directly

@Lee-W Lee-W merged commit afb9d3e into master Apr 12, 2024
@Lee-W Lee-W deleted the upgrade-publish-action-to-v4 branch April 12, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants