Skip to content

Conversation

@xidedix
Copy link
Member

@xidedix xidedix commented Jun 28, 2018

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Refactor

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

refactor(Breadcrumb): filter routeRecords array, getName cleanup

  • add computed routeRecords - filter for name or meta.label
  • rename showName to getName & cleanup

refactor(toggle-classes): add force toggle param

  • fixes SidebarToggler toggling on mount issue

refactor: SidebarToggler, AsideToggler

  • add defaultOpen prop
  • add toggle force param
  • cleanup
  • fixes SidebarToggler toggling on mount issue

xidedix added 4 commits June 28, 2018 16:44
- add computed `routeRecords` - filter for `name` or `meta.label`
- rename `showName` to `getName` & cleanup
- fixes SidebarToggler toggling issue
- add `defaultOpen` prop
- add toggle `force` param
- cleanup
- fixes `SidebarToggler` toggling on `mount` issue
@xidedix xidedix merged commit 07180cd into master Jun 28, 2018
@xidedix xidedix deleted the dev-vnext branch June 28, 2018 15:15
woothu pushed a commit that referenced this pull request Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants