Provisioning fix and upgrades #8209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
me-no-dev
reviewed
May 16, 2023
libraries/WiFiProv/src/WiFiProv.cpp
Outdated
| #include <esp_wifi.h> | ||
| #include <esp_event.h> | ||
| #include <esp32-hal.h> | ||
| #include "qrcode.h" |
Member
There was a problem hiding this comment.
you should check if that include exists and only then include and provide the new function. When building as component and qrcode component is not additionally installed, compilation will fail: https://github.com/espressif/arduino-esp32/actions/runs/4989420314/jobs/8933324447?pr=8209#step:4:1408
Contributor
Author
There was a problem hiding this comment.
I was expecting this to be available for all SoCs, I can see that is not, but do not understand why?
How can I test it?
Member
There was a problem hiding this comment.
it exists from the lib-builder, because it's installed with RainMaker, but as clean IDF+Arduino-as-component it does not exist for ANY chip.
Contributor
Author
There was a problem hiding this comment.
Should be resolved - CI passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #7748
The main problem is simply case size for the device name:
The IDF example is using upper case:
const char *ssid_prefix = "PROV_";line 210While the Arduino is using lower case (only the first letter is upper case):
arduino-esp32/libraries/WiFiProv/examples/WiFiProv/WiFiProv.ino
Line 50 in 3ec5f4e
This PR changes the device name to the same as the IDF name and also to what is expected by the app on default settings.
This should remove the confusion for first-time users.
This PR also added function for printing QR code (simply copied from the IDF example)
This PR also updates the README file.