Refactor: unpack and re-order HTMLParser.mainLoop foreign-content conditionals #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentation level of token handling logic
jayaddison
commented
Dec 31, 2020
| type in (StartTagToken, CharactersToken, SpaceCharactersToken))): | ||
| break | ||
|
|
||
| prev_token = new_token |
Contributor
Author
There was a problem hiding this comment.
NB: This is technically a behaviour change since prev_token could previously have referenced a ParseErrorToken. That said, I don't believe that the code that inspects the prev_token would ever be relevant for error tokens.
…content phase This is based on the idea that it's likely easier to understand the code -- and that it's hopefully less fragile -- if there is a single boolean with a readable name rather than repeated assignments to a variable that is invoked as a method call later
Contributor
Author
|
Cleaning up some old / stale pull requests; please let me know if this changeset is considered worthwhile and I'll reopen if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset should functionally be a no-op, and may be best reviewed with whitespace changes ignored since the indentation level for some of the loop's logic has been reduced.
The changes appear to result in a minor performance improvement; that said there are likely larger benefits to be found by further simplification and refactoring (perhaps including fairly substantial logical restructuring).
Before (2c19b98)
After (369a412)