Refactored to use common code from the non-java output! #29
Conversation
Gemfile
Outdated
There was a problem hiding this comment.
Ah, oops! Errr, that should be removed. I only put it in because I depended
on my special branch (open in the other PR) for this to run
On Thu, Nov 12, 2015 at 3:49 AM, Suyog Rao notifications@github.com wrote:
In Gemfile
#29 (comment)
:@@ -1,3 +1,4 @@
source 'https://rubygems.org'gemspec
+gem "logstash-output-elasticsearch", :path => "../logstash-output-elasticsearch"can we use LS_HOME here?
—
Reply to this email directly or view it on GitHub
https://github.com/logstash-plugins/logstash-output-elasticsearch_java/pull/29/files#r44637928
.
There was a problem hiding this comment.
Is this still supposed to be there?
There was a problem hiding this comment.
Will remove momentarily
|
This is a work of art now. So much cleanup. |
|
Thanks @untergeek :) . The tests still need more love, as does the protocol.rb file, but it's getting there! |
|
@untergeek and @talevy what needs to be done to move this toward LGTM? |
|
LGTM (@talevy is typing from my computer) :) |
|
Moved to #31 |
Depends on logstash-plugins/logstash-output-elasticsearch#302
All tests pass!