CI Maintenance: fix failing conda build #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why the conda resolver isn't doing this already...
Collaborator
Author
|
Okay that seems to have worked 🤷. I guess there may be a problem with pinning of one or more of the executablebooks packages on conda-forge? It'd be nice to fix this upstream, but in the meantime this gets our CI passing again. If anyone has experience with conda packaging and wants to fix this "properly" that'd be great! |
Collaborator
Author
|
I'm just going to go ahead an merge this so our CI is green again. I still suspect this is a packaging problem with one or more of the executablebooks projects on conda-forge; I'll open an issue to remind us to test the removal of this pin in the future, as this will (should? hopefully?) eventually be fixed upstream. |
Member
|
Thanks, @rossbar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the conda environment isn't working. My suspicion is that it's due to sphinx 5 - AFAIK the executablebooks tooling doesn't support sphinx 5 yet, so I would expect this to have been taken care of by the conda dependency resolver. Pip seems to get this right anyways...
Attempt number 1: manually pin sphinx.