Fixed titles for consistency in the index page #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
reviewed
Jun 5, 2021
| maxdepth: 1 | ||
| --- | ||
| content/tutorial-style-guide |
Member
There was a problem hiding this comment.
The style guide seems developer/contributor oriented. Why does it need to be included in the rendered site?
Collaborator
There was a problem hiding this comment.
Agreed - I think it would be best to separate out the contributor/developer info into it's own category separate from the pedagogical material itself; xref #85
rossbar
approved these changes
Jun 7, 2021
Collaborator
rossbar
left a comment
There was a problem hiding this comment.
+1 for consistency! Once we have a few more articles and start to explicitly categorize them via the diataxis framework we can maybe revisit the organization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some titles included "Tutorial" and some didn't - it seems like they should be consistent and since this is already the NumPy tutorials repo I think we can remove the word from the title.