Skip to content

OCPBUGS-3469: Multi-arch support #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
everettraven merged 1 commit into from
Mar 21, 2023
Merged

OCPBUGS-3469: Multi-arch support #114

everettraven merged 1 commit into from
Mar 21, 2023

Conversation

@oceanc80
Copy link
Contributor

@oceanc80 oceanc80 commented Mar 6, 2023

Add configurable multi-arch build support

everettraven
everettraven requested changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes currently don't work when attempting to initialize a project using operator-sdk init .... I left a comment showing the error I received and what I think the solution is.

Another thing I noticed is there is a few commits with multiple contributors and looks like it would re-commit a few already merged commits. I think a git rebase (or similar operation) may have gone a bit off the rails as I would have only expected the Makefile template and the testdata to be updated by this PR.

@oceanc80 oceanc80 force-pushed the multi-arch branch 2 times, most recently from 86f6323 to 8816187 Compare March 7, 2023 22:56
@oceanc80
Add configurable multi-arch build support
33d5369 
Signed-off-by: Catherine Chan-Tse <cchantse@redhat.com>
laxmikantbpandhare
laxmikantbpandhare approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I will try updated tutorial steps on the weekend.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2023
@everettraven
Copy link
Collaborator

everettraven commented Mar 9, 2023

So I think the changes look good and make sense, but I just can't seem to get an image to actually be built when running make docker-build. However, this isn't unique to this PR and also happens when trying to run make docker-build on the testdata/quarkus/memcached-quarkus-operator sample on the main branch.

everettraven
everettraven approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven everettraven merged commit 3398339 into operator-framework:main Mar 21, 2023
@oceanc80 oceanc80 deleted the multi-arch branch March 21, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@laxmikantbpandhare laxmikantbpandhare laxmikantbpandhare approved these changes

Assignees

@everettraven everettraven

@laxmikantbpandhare laxmikantbpandhare

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oceanc80 @everettraven @laxmikantbpandhare