Clarify and fix timeout value type #1120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@OndraM small reminder about this PR. Please let me know if anything is missing or unclear! |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to PHPStan, I noticed something "off" when on the client side we divide timeouts by 1000 (resulting in a float) but then this library multiplies them back by 1000 (timeouts on our side are in ms).
This library does not ensure that the correct timeout value type is passed, for example W3C does not allow float, but at the same time this library does not handle nulls.
With this PR, I'm trying to fix the following problems:
int|float("numbers"): https://www.selenium.dev/documentation/legacy/json_wire_protocol/#sessionsessionidtimeoutsnull|int: https://www.w3.org/TR/webdriver2/#timeouts