changed dict in stamp constructor from reference to shared ptr #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Added some spaces in blobstamper/stamp_dict.cpp for better readability (I forgot to add them there when I wrote it) Removed StampDictLCAlphaSmall class declaration, as it is not related to shared_ptr issue and should go in another commit |
Collaborator
|
The rest is seems to be good. Merging it into master brancg |
nataraj-hates-MS-for-stealing-github
added a commit
that referenced
this pull request
Jul 11, 2023
* changed dict in stamp constructor from reference to shared ptr --------- Co-authored-by: Григорьев Костя <kostyafip@mail.ru> Co-authored-by: nataraj-hates-MS-for-stealing-github <48326335+nataraj-hates-MS-for-stealing-github@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.