Code cleanup and tests stability #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code cleanup after merge of PGPRO-3253.
Also make free port choosing routine work on BSD-like systems (e.g. macOS).
arssher
reviewed
Apr 16, 2021
Cluster.pm
Outdated
|
|
||
| # advance $port, wrapping correctly around range end | ||
| $port = 26000 if ++$port == 27000; | ||
| $port = 26000 if ++$port >= 27000; |
Contributor
There was a problem hiding this comment.
== was actually intentional here, allowing run.pl to force its fixed 65432+ range
Contributor
|
For the record, this is from PGPRO-4965. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.