Add Dark mode #15
Merged
Add Dark mode #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Second commit also gives the code windows an updated look: Click to expand
|
starry-shivam
approved these changes
Apr 24, 2021
Member
starry-shivam
left a comment
There was a problem hiding this comment.
Tbh i dunno much about CSS and JavaScript so I can't actually review code changes 😅, but i do love dark mode, so great work!
harshil21
reviewed
Apr 24, 2021
Member
harshil21
left a comment
There was a problem hiding this comment.
I barely know anything either, but definitely like the updated code windows and dark mode!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as python-telegram-bot/python-telegram-bot#2483, just also made sure to update the GitHub-Buttons to reflect color preferences.
TBH I don't have the first idea about cherrypy & django, so here's what I did:
website/static/website/dark.csswebsite/templates/website/base.htmlI change the buttons (lines 66/67) and added thedark.cssin line 27python manage.py collectstaticWas that correct?
Here are two screenshots:
Click to expand
Again, if you don't like it, please just say so :)