Skip to content

Always use Turbo.fetch when available regardless of response kind #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelolx merged 3 commits into from
Dec 11, 2025
Merged

Always use Turbo.fetch when available regardless of response kind #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8320b8d
Always use Turbo.fetch when available, not just in turbo-stream requests
marcelolx Dec 11, 2025
71069bb
update deps
marcelolx Dec 11, 2025
79f3ac1
fix test
marcelolx Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions __tests__/fetch_request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ describe('query params are parsed', () => {


describe('turbostream', () => {
test('turbo fetch is called for turbo-stream responseKind', async() => {
test('turbo fetch is called when available', async() => {
const mockResponse = new Response("success!", { status: 200 })

window.fetch = jest.fn().mockResolvedValue(mockResponse)
Expand All @@ -326,16 +326,15 @@ describe('turbostream', () => {
expect(testResponse).toStrictEqual(new FetchResponse(mockResponse))
})

test('turbo fetch is called for other responseKind', async() => {
test('turbo fetch is not called when not available', async() => {
const mockResponse = new Response("success!", { status: 200 })

window.fetch = jest.fn().mockResolvedValue(mockResponse)
window.Turbo = { fetch: jest.fn().mockResolvedValue(mockResponse) }
window.Turbo = undefined

const testRequest = new FetchRequest("get", "localhost")
const testRequest = new FetchRequest("get", "localhost", { responseKind: 'turbo-stream' })
const testResponse = await testRequest.perform()

expect(window.Turbo.fetch).toHaveBeenCalledTimes(0)
expect(window.fetch).toHaveBeenCalledTimes(1)
expect(testResponse).toStrictEqual(new FetchResponse(mockResponse))
})
Expand Down
5 changes: 1 addition & 4 deletions src/fetch_request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ export class FetchRequest {
console.error(error)
}

const fetch = (this.responseKind === 'turbo-stream' && window.Turbo)
? window.Turbo.fetch
: window.fetch

const fetch = window.Turbo ? window.Turbo.fetch : window.fetch
const response = new FetchResponse(await fetch(this.url, this.fetchOptions))

if (response.unauthenticated && response.authenticationURL) {
Expand Down
Loading