Skip to content

fix: Fix infinite evict loop on text unload #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avelad merged 1 commit into from
Nov 3, 2025
Merged

fix: Fix infinite evict loop on text unload #9331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/media/streaming_engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2697,6 +2697,9 @@ shaka.media.StreamingEngine = class {
* @private
*/
async evict_(mediaState, presentationTime) {
if (this.lastTextMediaStateBeforeUnload_ == mediaState) {
this.lastTextMediaStateBeforeUnload_ = null;
}
const segmentIndex = mediaState.stream.segmentIndex;
/** @type {Array<number>} */
let continuityTimelines;
Expand All @@ -2723,9 +2726,6 @@ shaka.media.StreamingEngine = class {
const startTime =
this.playerInterface_.mediaSourceEngine.bufferStart(mediaState.type);
if (startTime == null) {
if (this.lastTextMediaStateBeforeUnload_ == mediaState) {
this.lastTextMediaStateBeforeUnload_ = null;
}
shaka.log.v2(logPrefix,
'buffer behind okay because nothing buffered:',
'presentationTime=' + presentationTime,
Expand Down