Update http_kernel_httpkernel_class.rst #10116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove suffix Action from path to ErrorController. Otherwise it doesn't work.
Member
|
@mkurc1 super nice catch! Thanks for fixing it. We merged it in 4.0 (the oldest maintained branch which contains the bug) and we'll merge it in the upper branches automatically later. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 25, 2018
This PR was submitted for the 4.1 branch but it was merged into the 4.0 branch instead (closes #10116). Discussion ---------- Update http_kernel_httpkernel_class.rst Remove suffix Action from path to ErrorController. Otherwise it doesn't work. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- a6e0890 Update http_kernel_httpkernel_class.rst
javiereguiluz
pushed a commit
that referenced
this pull request
Jul 26, 2018
Remove suffix Action from path to ErrorController. Otherwise it doesn't work. Same problem as #10116.
javiereguiluz
added a commit
that referenced
this pull request
Jul 26, 2018
This PR was submitted for the 4.1 branch but it was merged into the 4.0 branch instead (closes #10117). Discussion ---------- Update dependency_injection.rst Remove suffix Action from path to ErrorController. Otherwise it doesn't work. Same problem as #10116. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 8b39f1e Update dependency_injection.rst
Guikingone
pushed a commit
to Guikingone/symfony-docs
that referenced
this pull request
Feb 12, 2019
Remove suffix Action from path to ErrorController. Otherwise it doesn't work. Same problem as symfony#10116.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove suffix Action from path to ErrorController. Otherwise it doesn't work.