Skip to content

Testing: Fix typo from #6427 #7748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabbuh merged 1 commit into from
Apr 8, 2017
Merged

Testing: Fix typo from #6427 #7748

xabbuh merged 1 commit into from
Apr 8, 2017

Conversation

@alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Apr 2, 2017

Fix typo introduced in #6427: $this->request → $request

HeahDude
HeahDude approved these changes Apr 3, 2017
View reviewed changes
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Apr 3, 2017

@HeahDude I introduced the typo by myself in my previous PR, it was easy to catch. 😉

javiereguiluz
javiereguiluz approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xabbuh
Copy link
Member

xabbuh commented Apr 8, 2017

Thank you @alexislefebvre.

@xabbuh xabbuh merged commit 3a9a4f0 into symfony:2.7 Apr 8, 2017
xabbuh added a commit that referenced this pull request Apr 8, 2017
@xabbuh
minor #7748 Testing: Fix typo from #6427 (alexislefebvre)
99247f7 
This PR was merged into the 2.7 branch.

Discussion
----------

Testing: Fix typo from #6427

Fix typo introduced in #6427: `$this->request` → `$request`

Commits
-------

3a9a4f0 Testing: Fix typo from #6427
@alexislefebvre alexislefebvre deleted the patch-2 branch October 20, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

+1 more reviewer

@HeahDude HeahDude HeahDude approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexislefebvre @xabbuh @javiereguiluz @HeahDude @carsonbot