Skip to content

fixes issue 374 #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
standlove merged 1 commit into from
Jan 16, 2019
Merged

fixes issue 374 #460

standlove merged 1 commit into from
Jan 16, 2019

Conversation

@sumitdaga
Copy link
Contributor

@sumitdaga sumitdaga commented Jan 16, 2019

No description provided.

@sumitdaga
Copy link
Contributor Author

sumitdaga commented Jan 16, 2019

ok so the issue here was that javascript slice function was incorrectly used ...the same issue can be seen even in the instance root page (if you click on a instance) ...if pageSize is 20 only 19 elements could be seen ...i have fixed slice function at these two places as part of this PR
slice function is used at two other places ...i will look into them about there correctness

@standlove standlove merged commit b65d32c into master Jan 16, 2019
@standlove standlove deleted the issue-374 branch January 17, 2019 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sumitdaga @standlove