Skip to content

Bugfix #125 - Extension changes the default Locale to en.US #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippSalvisberg merged 2 commits into from
Jan 4, 2021
Merged

Bugfix #125 - Extension changes the default Locale to en.US #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df85bd8
Revert "ensure that the test runs in all environments"
PhilippSalvisberg Jan 4, 2021
7671c8b
ensure that the test runs independent of the system locale settings
PhilippSalvisberg Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sqldev/src/main/java/org/utplsql/sqldev/ui/runner/SmartTime.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
package org.utplsql.sqldev.ui.runner;

import java.text.DecimalFormat;
import java.util.Locale;

public class SmartTime {
private Double seconds;
Expand Down Expand Up @@ -46,7 +45,6 @@ public Double getSeconds() {

@Override
public String toString() {
Locale.setDefault(new Locale("en", "US"));
String ret;
if (seconds == null) {
ret = null;
Expand Down
8 changes: 8 additions & 0 deletions sqldev/src/test/java/org/utplsql/sqldev/test/runner/SmartTimeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,19 @@
*/
package org.utplsql.sqldev.test.runner;

import java.util.Locale;

import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import org.utplsql.sqldev.ui.runner.SmartTime;

public class SmartTimeTest {

@Before
public void setup() {
Locale.setDefault(new Locale("en", "US"));
}

@Test
public void null_default() {
Expand Down