Skip to content

Conversation

@bnjmnt4n
Copy link
Contributor

Closes #412.

Not too sure if I should edit any of the tests, please let me know if you want me to do so :)

@mathiasbynens mathiasbynens merged commit f464d6b into jsperf:master Dec 11, 2017
@mathiasbynens
Copy link
Contributor

Thanks a lot, @bnjmnt4n! Deploying now.

@mathiasbynens
Copy link
Contributor

@maxbeatty I’m having issues deploying with now. Is everything working for you?

> Deploying ~/projects/jsperf.com under mathias
> Using Node.js 8.9.1 (requested: `8.x.x`)
> Ready! https://jsperfcom-dumuiyqstt.now.sh (copied to clipboard) [9s]
> Synced 1 file (334.75KB) [0ms]
> Initializing…
> Initializing…
> Building
> ▲ npm install
> ✓ Using "package-lock.json"
> ⧗ Installing 30 main dependencies…
> ✓ Installed 1226 modules [10s]
> ▲ npm start
> > jsperf.com@2.0.0 start /home/nowuser/src
> > node server.js
> No open port found. Make sure 'npm start' creates an HTTP server on a port (any).
> More details: https://err.sh/now-cli/no-open-port-found

@bnjmnt4n bnjmnt4n deleted the fix-asynchronous-edits branch December 12, 2017 02:34
@maxbeatty
Copy link
Member

starts up for me locally. can you double-check that @jsperf-loggly-token secret is set properly? there aren't any logs and that's where this startup issue should explain itself (could also just enable good-console always)

@mathiasbynens
Copy link
Contributor

Nothing has changed about the now/ZEIT setup:

$ now secrets ls | grep jsperf-loggly-token
  jsperf-loggly-token      323d ago

😕

maxbeatty added a commit that referenced this pull request Oct 9, 2018
* master:
  Adding X-UA-Compatible in the head (#471)
  fix: .snyk & package.json to reduce vulnerabilities (#477)
  add link to wiki (#466)
  Fix issue with bad updates causing disappearing tests (#464)
  Fix cache start (#453)
  Ensure that edited test cases can be set as synchronous/asynchronous 
(#451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants