Update package-lock.json #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxbeatty
reviewed
Dec 12, 2017
package.json
Outdated
| "version": "2.0.0", | ||
| "description": "jsPerf aims to provide an easy way to create and share test cases, comparing the performance of different JavaScript snippets by running benchmarks", | ||
| "description": | ||
| "jsPerf aims to provide an easy way to create and share test cases, comparing the performance of different JavaScript snippets by running benchmarks", |
Member
There was a problem hiding this comment.
prettier may have nabbed this :/
maxbeatty
reviewed
Dec 12, 2017
| "now": { | ||
| "alias": "jsperf.com" | ||
| "alias": "jsperf.com", | ||
| "env": { |
Member
There was a problem hiding this comment.
thought this was easier to manage
Contributor
Author
There was a problem hiding this comment.
It totally is! Thanks
Member
|
Hijacking this branch to debug this 😈 will you try to deploy this branch to now? should have more insight into why it isn't starting up with these changes |
Contributor
Author
|
Deploying… |
Contributor
Author
|
maxbeatty
reviewed
Dec 12, 2017
| server.expose('drop', client.drop.bind(client)); | ||
|
|
||
| client.start(next); | ||
| client.start().then(next).catch(next); |
Member
There was a problem hiding this comment.
catbox client start changed to being promise-based after v7 (oops) hopefully this solves the stall when connecting to rediscover
Contributor
Author
|
That fixes it! ♥ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.