-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(UI): Allow play in VR in all compatible devices #9297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since VR movement can be controlled with specific methods we should not limit its use
Member
Author
|
@shaka-bot test |
Collaborator
|
@avelad: Lab tests started with arguments:
|
Member
Author
|
@shaka-bot test |
Collaborator
|
@avelad: Lab tests started with arguments:
|
tykus160
approved these changes
Oct 27, 2025
Collaborator
|
Incremental code coverage: 100.00% |
avelad
added a commit
that referenced
this pull request
Oct 27, 2025
Since VR movement can be controlled with specific methods we should not limit its use
avelad
added a commit
that referenced
this pull request
Oct 27, 2025
Since VR movement can be controlled with specific methods we should not limit its use
This was referenced Oct 27, 2025
avelad
added a commit
that referenced
this pull request
Oct 27, 2025
Since VR movement can be controlled with specific methods we should not limit its use
avelad
added a commit
that referenced
this pull request
Oct 27, 2025
Since VR movement can be controlled with specific methods we should not limit its use
cotid-qualabs
pushed a commit
to qualabs/shaka-player
that referenced
this pull request
Nov 3, 2025
Since VR movement can be controlled with specific methods we should not limit its use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: UI
The issue involves the Shaka Player UI
priority: P2
Smaller impact or easy workaround
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since VR movement can be controlled with specific methods we should not limit its use