Skip to content

fix(UI): Allow play in VR in all compatible devices #9297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avelad merged 2 commits into from
Oct 27, 2025
Merged

fix(UI): Allow play in VR in all compatible devices #9297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c220502
feat(UI): Allow play in VR in all compatible devices
avelad Oct 27, 2025
68f8349
fix lint
avelad Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat(UI): Allow play in VR in all compatible devices 
Since VR movement can be controlled with specific methods we should not limit its use
  • Loading branch information
@avelad
avelad committed Oct 27, 2025
commit c22050295dbbf87309298c38f209765ddc8f13bb
11 changes: 1 addition & 10 deletions ui/vr_manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,16 +383,7 @@ shaka.ui.VRManager = class extends shaka.util.FakeEventTarget {
* @private
*/
getGL_(canvas) {
if (!canvas) {
return null;
}
// The user interface is not intended for devices that are controlled with
// a remote control, and WebGL may run slowly on these devices.
const device = shaka.device.DeviceFactory.getDevice();
const deviceType = device.getDeviceType();
if (deviceType == shaka.device.IDevice.DeviceType.TV ||
deviceType == shaka.device.IDevice.DeviceType.CONSOLE ||
deviceType == shaka.device.IDevice.DeviceType.CAST) {
if (!canvas || !window.WebGLRenderingContext) {
return null;
}
const webglContexts = [
Expand Down
Loading