Skip to content

fix: Fix infinite evict loop on text unload #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avelad merged 1 commit into from
Nov 3, 2025
Merged

fix: Fix infinite evict loop on text unload #9331

avelad merged 1 commit into from
Nov 3, 2025

Conversation

@tykus160
Copy link
Member

@tykus160 tykus160 commented Nov 3, 2025

Steps to retroduce:

  1. Load content with CEA captions
  2. Enable subtitles
  3. Disable subtitles
  4. Wait for a few minutes - application will hang due to recursive callbacks on text unload.

Issue is a regression introduced by combination of #7360 & #9068

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Nov 3, 2025
@avelad avelad added this to the v5.0 milestone Nov 3, 2025
@avelad avelad self-requested a review November 3, 2025 09:21
@shaka-bot
Copy link
Collaborator

shaka-bot commented Nov 3, 2025

Incremental code coverage: 66.67%

@avelad avelad merged commit 5c5c72e into shaka-project:main Nov 3, 2025
31 of 34 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 3, 2025
Open
@tykus160 tykus160 deleted the wt-fix-recursion branch November 3, 2025 12:16
avelad pushed a commit that referenced this pull request Nov 3, 2025
@tykus160 @avelad
fix: Fix infinite evict loop on text unload (#9331)
760d192 
Steps to retroduce:
1. Load content with CEA captions
2. Enable subtitles
3. Disable subtitles
4. Wait for a few minutes - application will hang due to recursive
callbacks on text unload.

Issue is a regression introduced by combination of #7360 & #9068
@shaka-bot shaka-bot mentioned this pull request Nov 3, 2025
Merged
avelad pushed a commit that referenced this pull request Nov 3, 2025
@tykus160 @avelad
fix: Fix infinite evict loop on text unload (#9331)
b8a1823 
Steps to retroduce:
1. Load content with CEA captions
2. Enable subtitles
3. Disable subtitles
4. Wait for a few minutes - application will hang due to recursive
callbacks on text unload.

Issue is a regression introduced by combination of #7360 & #9068
@shaka-bot shaka-bot mentioned this pull request Nov 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avelad avelad avelad approved these changes

Assignees

No one assigned

Labels

component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly

Projects

None yet

Milestone

v5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tykus160 @shaka-bot @avelad