Class constructor error with declarations

Question

I am getting errors with this, NetBeans is telling me it was expecting something on the last line of the $xml_package declaration. Any ideas what I am missing?

Thank you.

class foo
{
    public function __construct()
    {
        public $rateRequest = 'RateV4Request';

        public $xml_request = '<'. $rateRequest. '><Revision></Revision></'.
                              $rateRequest. '>';

        public $xml_package = '<Package><Service></Service><ZipOrigination>
                        </ZipOrigination><ZipDestination></ZipDestination>
                        <Pounds></Pounds><Ounces></Ounces><Container>
                        </Container><Size></Size></Package>';
    }
}

Please include the error text in your post. Is this wrapped in <?php and ?> tags? — Madbreaks
– Madbreaks, Commented Apr 19, 2012 at 21:58
I have the opening <?php tag but I don't close it. I have read it is better to leave it open? But Mark's answer below fixed it for me. — Bead
– Bead, Commented Apr 19, 2012 at 22:01

Mark Baker · Accepted Answer · 2012-04-19 21:59:44Z

3

That's because you're declaring your properties in the constructor itself, not in the class

class foo 
{ 
    protected $rateRequest; 

    protected $xml_request; 

    protected $xml_package; 

    public function __construct() 
    { 
        $this->rateRequest = 'RateV4Request'; 

        $this->xml_request = '<'. $this->rateRequest. '><Revision></Revision></'. 
                              $this->rateRequest. '>'; 

        $this->xml_package = '<Package><Service></Service><ZipOrigination> 
                        </ZipOrigination><ZipDestination></ZipDestination> 
                        <Pounds></Pounds><Ounces></Ounces><Container> 
                        </Container><Size></Size></Package>'; 
    } 
}

answered Apr 19, 2012 at 21:59

Mark Baker

213k34 gold badges354 silver badges390 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Bead Over a year ago

Thank you, that fixed my problem! I am trying to learn OOP and this all new to me.

hakre Over a year ago

hows public adequately represented with protected? And if you want to hide, suggest private and not protected.

Mark Baker Over a year ago

@hakre - I could have left them as public, it's just personal habit (I'm a strong believer in getters/setters to control access to properties, but in allowing properties to be redeclared within the inheritance hierarchy

hakre Over a year ago

@MarkBaker: But if you like getters / setters, why do you make it protected and not private?

Mark Baker Over a year ago

@hakre - comments against an answer isn't a good medium for the relative merits of different visibilities... but the simple answer is that private properties can't be redeclared in a child class

|

Collectives™ on Stack Overflow

Class constructor error with declarations

1 Answer 1

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related