UPDATE MySQL Syntax Error

Question

I am getting an SQl syntax error when running the following query and can not see what is wrong with it:

$query = "UPDATE combined SET v_categories_name_1_1='Hoodie', 
v_attribute_options_id_1=1, v_attribute_values_id_1_1=1, v_attribute_values_id_1_2=2, 
v_attribute_values_id_1_3=3, v_attribute_values_id_1_4=4, 
v_attribute_values_price_1_1=0, v_attribute_values_price_1_2=0, 
v_attribute_values_price_1_3=0, v_attribute_values_price_1_4=0, 
v_attribute_options_name_1_1='Size', v_attribute_values_name_1_1_1='Small', 
v_attribute_values_name_1_2_1='Medium', v_attribute_values_name_1_3_1='Large', 
v_attribute_values_name_1_4_1='Extra Large') " .
"WHERE v_products_model='$fileName'";

And here is the error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') WHERE v_products_model=hs_3stm_giantsk.jpg' at line 1

UPDATE:

Thanks everyone for the super fast replies, it's solved my problem though unfortunately I can't accept them for another 9 minutes!

If you find any of the answers helpful, please accept it as the correct answer so this question can be marked as resolved. If you still have issues with it, I would love to assist. Thanks! — dvir
– dvir, Commented Jun 28, 2012 at 0:15

kitti · Accepted Answer · 2012-05-10 21:01:05Z

Try formatting your queries; problems become much more apparent:

$query = "
    UPDATE combined SET 
        v_categories_name_1_1='Hoodie', 
        v_attribute_options_id_1=1,
        v_attribute_values_id_1_1=1,
        v_attribute_values_id_1_2=2, 
        v_attribute_values_id_1_3=3, 
        v_attribute_values_id_1_4=4, 
        v_attribute_values_price_1_1=0, 
        v_attribute_values_price_1_2=0, 
        v_attribute_values_price_1_3=0,
        v_attribute_values_price_1_4=0, 
        v_attribute_options_name_1_1='Size',
        v_attribute_values_name_1_1_1='Small', 
        v_attribute_values_name_1_2_1='Medium', 
        v_attribute_values_name_1_3_1='Large', 
        v_attribute_values_name_1_4_1='Extra Large')
    WHERE v_products_model='$fileName'
";

That bad paren is much easier to notice when you're not just looking at one big blob of text. You would (hopefully) never write PHP like that, so why write your SQL like that?

Ignacio Vazquez-Abrams · Accepted Answer · 2012-05-10 20:55:33Z

2

You close parens that you you never open.

answered May 10, 2012 at 20:55

Ignacio Vazquez-Abrams

804k160 gold badges1.4k silver badges1.4k bronze badges

Comments

dvir · Accepted Answer · 2012-05-10 20:55:40Z

2

You have an odd ) at the end of the line before the last.

answered May 10, 2012 at 20:55

dvir

5,1241 gold badge25 silver badges32 bronze badges

Comments

Andrius Naruševičius · Accepted Answer · 2012-05-10 20:56:29Z

2

There is a symbol ) appearing for no reason :)

answered May 10, 2012 at 20:56

Andrius Naruševičius

8,6289 gold badges53 silver badges83 bronze badges

Comments

Karo · Accepted Answer · 2012-05-10 20:57:00Z

2

Try this

$query = "UPDATE combined SET v_categories_name_1_1='Hoodie', 
v_attribute_options_id_1=1, v_attribute_values_id_1_1=1, v_attribute_values_id_1_2=2, 
v_attribute_values_id_1_3=3, v_attribute_values_id_1_4=4, 
v_attribute_values_price_1_1=0, v_attribute_values_price_1_2=0, 
v_attribute_values_price_1_3=0, v_attribute_values_price_1_4=0, 
v_attribute_options_name_1_1='Size', v_attribute_values_name_1_1_1='Small', 
v_attribute_values_name_1_2_1='Medium', v_attribute_values_name_1_3_1='Large', 
v_attribute_values_name_1_4_1='Extra Large' " .
"WHERE v_products_model='$fileName'";

I removed the bracket before WHERE clause.

answered May 10, 2012 at 20:57

Karo

7444 silver badges7 bronze badges

Comments

Maksym Polshcha · Accepted Answer · 2012-05-10 20:58:16Z

2

Enclosing bracket with no opening one here

='Extra Large')

answered May 10, 2012 at 20:58

Maksym Polshcha

18.4k8 gold badges54 silver badges78 bronze badges

Collectives™ on Stack Overflow

UPDATE MySQL Syntax Error

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related