Insert error in mysql/php

Question

I have got this function:

   public static function insert_user($user)
{
    $con = mysql_connect("localhost","root","") or die(mysql_error());
    mysql_select_db("speakom",$con) or die(mysql_error());
    mysql_query("INSERT INTO user (user_ip,user_name,full_name,email_address,password,gender,birthday,banned,role,country) 
        VALUES('".$user->ip."','".$user->name."','".$user->full_name."','".$user->email."','".$user->password."',".$user->gender.",'".$user->birthday."',".$user->banned.",".$user->role.",'".$user->country."'") or die(mysql_error());
    mysql_close($con);
}

And I get this error:

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 2

Where does the error point to ? how do I know where the error is?

eggyal · Accepted Answer · 2012-05-11 11:54:49Z

3

You're missing the closing ) from the VALUES ( clause. In general, it's easier to assign your SQL to a variable (which you can output for debugging purposes like this) prior to passing it to mysql_query.

answered May 11, 2012 at 11:54

eggyal

127k18 gold badges221 silver badges245 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ja͢ck · Accepted Answer · 2012-05-11 12:03:09Z

Instead of yelling you should use PDO and prepared statements, here's the answer in PDO style:

$con = new PDO('mysql:host=localhost;dbname=speakom', 'root', ''); // optionally add encoding options
$con->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION); // enable exception throwing
$stmt = $db->prepare('INSERT INTO user (user_ip, user_name, full_name, email_address, password, gender, birthday, banned, role, country) 
    VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)');
$stmt->execute(array(
    $user->ip, $user->name, $user->full_name, $user->email, $user->password, 
    $user->gender, $user->birthday, $user->banned, $user->role, $user->country,
));

Disclaimer didn't test this, but it should give you a good idea :)

triclosan · Accepted Answer · 2012-05-11 11:55:43Z

1

would you run

echo "INSERT INTO user (user_ip,user_name,full_name,email_address,password,gender,birthday,banned,role,country)      VALUES('".$user->ip."','".$user->name."','".$user->full_name."','".$user->email."','".$user->password."',".$user->gender.",'".$user->birthday."',".$user->banned.",".$user->role.",'".$user->country."'";

and i advise you to use `user` instead of user

answered May 11, 2012 at 11:55

triclosan

5,7846 gold badges31 silver badges53 bronze badges

Comments

Leri · Accepted Answer · 2012-05-11 11:56:34Z

1

VALUES('".$user->ip."','".$user->name."','".$user->full_name."','".$user->email."','".$user->password."',".$user->gender.",'".$user->birthday."',".$user->banned.",".$user->role.",'".$user->country."'"

You are missing ) at the end. By the way, use PDO or mysqli.

answered May 11, 2012 at 11:56

Leri

12.6k7 gold badges46 silver badges60 bronze badges

2 Comments

Dmitry Makovetskiyd Over a year ago

what does it give me mysqli? are those prepared statements?

Leri Over a year ago

@DmitryMakovetskiyd Yes, they are. php.net/manual/en/book.mysqli.php and php.net/manual/en/book.pdo.php

Chibuzo · Accepted Answer · 2012-05-11 11:56:39Z

1

Some of the values you want to insert are not in quote, and you missed the closing ) for VALUES. Try this

mysql_query("INSERT INTO user (user_ip,user_name,full_name,email_address,password,gender,birthday,banned,role,country) 
    VALUES('$user->ip', '$user->name','$user->full_name', '$user->email', '$user->password', '$user->gender', '$user->birthday', '$user->banned', '$user->role', '$user->country')") or die(mysql_error());

answered May 11, 2012 at 11:56

Chibuzo

6,1133 gold badges33 silver badges54 bronze badges

Collectives™ on Stack Overflow

Insert error in mysql/php

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related