Javascript function to open a file not getting called

Question

i am having problem in calling javascript function
I want to open a file on click of a link.

Here is my code:

<script language="javascript" type="text/javascript">
var refViewer = null;

function OpenViewerWindow(image) {
    return window.open(image, "Viewer", "height=400px,width=550px,menubar=no,scrollbars=yes ,resizable=yes,top=100px,left=234px");

}


function openViewer(image) {

    if (refViewer != null) {
        if (refViewer.closed == false) {
            refViewer.close();
            refViewer = OpenViewerWindow(image);
        }
        else refViewer = OpenViewerWindow(image);
    }
    else
        refViewer = OpenViewerWindow(image);
}   


</script>

<a onclick=javascript:openViewer(@ViewBag.path)><img src="pic.jpg"/></a>

and the in the controller:

 public ActionResult ActivityPosting(int HobbyDetailID)
    {
string filepath = Server.MapPath("~/ePortfolio/PortFolioContent/" + HobbyDetailID + "/ReferenceMaterial/" + item.FilePath);
 ViewBag.path = filepath;
    return view();
   }

The problem is the javascript function does not get called.Please help me

Mathew Thompson · Accepted Answer · 2012-05-24 11:04:57Z

0

Try this instead in your JavaScript OpenViewerWindow function (you need to use the file:// protocol:

return window.open("file://" + image, "Viewer", "height=400px,width=550px,menubar=no,scrollbars=yes   ,resizable=yes,top=100px,left=234px")

answered May 24, 2012 at 11:04

Mathew Thompson

56.5k15 gold badges131 silver badges151 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

user1274646 Over a year ago

the problem is openViewer() function itself is not getting called

Mathew Thompson Over a year ago

Try changing your a tag to be this: <a onclick="openViewer('@ViewBag.path');"><img src="pic.jpg"/></a>

Mathew Thompson Over a year ago

Can you tell us your exact filepath in the @ViewBag.path variable that the window is trying to open? That must be wrong.

user1274646 Over a year ago

ya the file path is:E:\HOBBYHOMES(E-PORTFOLIO)\ePortfolio\e-Portfolio\PortFolioContent\1\ReferenceMaterial\prtf_1.docx

Mathew Thompson Over a year ago

Ah try my edit, it must start with file:/// not file:// what I put originally :)

|

Darin Dimitrov · Accepted Answer · 2012-05-24 11:38:35Z

0

Make sure you pass a string:

<a onclick=javascript:openViewer('@ViewBag.path')><img src="pic.jpg"/></a>

Notice the single quotes. Or even better use Json.Encode to ensure proper encoding of the value that is passed to your openViewer javascript function:

<a onclick="javascript:openViewer(@Html.Raw(Json.Encode(ViewBag.path)))"><img src="pic.jpg"/></a>

Also there's another issue with your code. You use Server.MapPath to calculate the url but this method returns the absolute path to the file on the server. The client obviously cannot access it with an absolute path. You should pass an url using the Url.Content helper:

public ActionResult ActivityPosting(int HobbyDetailID)
{
    string filepath = Url.Content("~/ePortfolio/PortFolioContent/" + HobbyDetailID + "/ReferenceMaterial/" + item.FilePath");
    ViewBag.path = filepath;
    return View();
}

edited May 24, 2012 at 11:38

answered May 24, 2012 at 11:06

Darin Dimitrov

1.0m277 gold badges3.3k silver badges3k bronze badges

3 Comments

Darin Dimitrov Over a year ago

Oops, that's because I forgot to set ViewBag.path = filepath; in my example. I have updated.

user1274646 Over a year ago

the function is getting called but the file is not opening

Darin Dimitrov Over a year ago

That's another problem with the url that you are requesting. Maybe there's some issue with it.

Collectives™ on Stack Overflow

Javascript function to open a file not getting called

2 Answers 2

7 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related