Global array undefined

Question

I have a simple jQuery script to show/hide list elements accordion-style along with a global boolean array to save which lists are shown/hidden. However, when switching from show/hiding different sublists, the boolean array goes undefined, ie (I call function with form_nav_links to show that list, then when I try to show help_nav_links right after, the array is undefined and requires an extra click). Can someone help me fix this? Here is what I have:

var listsOn = Boolean[2];
listsOn = [false, false];
var form_links = 0, help_links = 1;

function toggleView(subList) {
    var i;

    switch(subList){
        case "form_nav_links":
            i = form_links;
            break;
        case "help_nav_links":
            i = help_links;
            break;
        };

    if(listsOn[i]){
        $("." + subList).slideUp(1000);
        listsOn[i] = false;
        }
    else {
        $("." + subList).slideDown(1000);
        listsOn[i] = true;
        }

Thanks in advance!

^^ well that's just sooo much better, varela. That beautifully knocks it down to 1 line =) — Austin
– Austin, Commented Jun 27, 2012 at 19:30

Dancrumb · Accepted Answer · 2012-06-27 18:21:48Z

1

You really ought to be using an associative array here:

var listsOn = {
  form_nav_links: false,
  help_nav_links: false
};

function toggleView(subList) {
  if(typeof listsOn[subList] !== 'undefined') {
    if(listsOn[subList]{
        $("." + subList).slideUp(1000);
        listsOn[subList] = false;
    }
    else {
        $("." + subList).slideDown(1000);
        listsOn[subList] = true;
    }
  }
}

answered Jun 27, 2012 at 18:21

Dancrumb

27.7k10 gold badges79 silver badges139 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

varela Over a year ago

wow, strict equal to 'undefined' string, what else you expect from typeof?

Austin Over a year ago

ah, I had that originally but then got stuck trying to access the bools like listsOn.blah (I'm less than a week into JS)

Dancrumb Over a year ago

@varela: no reason not to use strict equal and it's easier to have an established habit of using strict equality than switching and leaving it to the maintainer to determine whether an unstrict equality operator is acceptable.

Austin · Accepted Answer · 2012-07-25 15:46:11Z

0

I solved the issue by using slideToggle() instead

answered Jul 25, 2012 at 15:46

Austin

1,0733 gold badges14 silver badges27 bronze badges

Collectives™ on Stack Overflow

Global array undefined

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related