"bbcode" script not working

Question

This is a jQuery variant of a script (it doesn't work):

<script language="javascript">
$("div.post-content").each(function(){
    if($(this).innerHTML.indexOf("[/float]") != -1) {
        pattern= /\[float=(.*?)\]([^\[]*)\[\/float\]/gi
        $(this).html($(this).innerHTML.replace(pattern, "<span style='float: $1;'>$2</span>"))
    }
})
</script>

This is the pure Javascript variant (it works perfectly):

<script language="javascript">
posts=document.getElementsByTagName("div")
for(x in posts) if(posts[x].className=="post-content") {
    post = posts[x].innerHTML;
    if(post.indexOf("[/float]") != -1) {
        pattern = /\[float=(.*?)\]([^\[]*)\[\/float\]/gi
        posts[x].innerHTML = posts[x].innerHTML.replace(pattern, "<span style='float: $1;'>$2</span>")
    }
}
</script>

What this script does:

It seeks out all divs with class post-content.
It checks whether there's a closing tag for bbcode.
By using regular expression, it seeks out patterns of given bbcode tags.
It replaces bbcode tags with html element.

I don't know what I did wrong here...

Start by replacing innterHTML with innerHTML

fvu
– fvu

2012-06-30 09:23:28 +00:00
Commented Jun 30, 2012 at 9:23 — fvu
– fvu, Commented Jun 30, 2012 at 9:23
awww, crap. Dat typo. Still not working tho.

Fletus Mefitis
– Fletus Mefitis

2012-06-30 09:26:47 +00:00
Commented Jun 30, 2012 at 9:26 — Fletus Mefitis
– Fletus Mefitis, Commented Jun 30, 2012 at 9:26

MaxArt · Accepted Answer · 2012-06-30 09:29:14Z

2

Don't use innerHTML when using jQuery. It's wrong when assigning a value (memory leaks), and a bad practice when reading a value. Use

$(this).html()

or, if you really want to,

$(this)[0].innerHTML

The jQuery object returns an array, that doesn't have a innerHTML property. But then again, use .html() for a code more of the style of jQuery.

answered Jun 30, 2012 at 9:29

MaxArt

22.8k10 gold badges85 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

scessor Over a year ago

A third variant is to replace $(this).innerHTML with $(this).get(0).innerHTML.

MaxArt Over a year ago

@scessor Yes, I've forgot about that because I've never seen the point of it, so never used it. It's just a slower function call when you can directly access the element in the array.

Collectives™ on Stack Overflow

"bbcode" script not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related