Python: typeerrors, numbers that are not integers, and variable problems

Question

So im trying to make a program that asks for 3 numbers and then returns the product of those numbers (determining the volume of a cuboid)

def cuboid ():
    A = input('Height '),
    B = input('Width '),
    C = input('Depth '),

So far this makes PYthon ask for the three values, but i don't know hot to tell python that they are not strings, but integers. i.e. i don't know how to use the int() command. so if after that I type: Volume = A*B*Cit gives a TypeError because he thinks that 1,2 and 3 are not integers.

I don't know why it doesn't work that way, because a rough

def o3 (x,y,z):
    print x*y*z

does work. Thanks in advance

Tim Pietzcker · Accepted Answer · 2012-07-17 10:36:29Z

1

You're using input() where you should be using raw_input(). After the input, you then just need to say a = int(a) and a will be an integer which you can do normal arithmetic on.

example:

def get_cube_dims():
    x = int( raw_input('Enter x:') )
    y = int( raw_input('Enter y:') )
    z = int( raw_input('Enter z:') )
    print 'The volume is: {}'.format(x*y*z)

edited Jul 17, 2012 at 10:36

Tim Pietzcker

337k59 gold badges520 silver badges572 bronze badges

answered Jul 17, 2012 at 10:25

Jon Clements

143k34 gold badges254 silver badges288 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Tim Pietzcker Over a year ago

No, he's using Python 2 (see the print statement), and that's precisely why his approach "works" - input() in Python 2 evaluates the input string as a Python expression.

Javicobos Over a year ago

Like this:

def cuboid (): 	    A = input('Height '), 	    B = input('Width '), 	    C = input('Depth '), 	    A = int(A) 	    B = int(B) 	    C = int(C) 	    print A*B*C

? Doesnt work either

Jon Clements Over a year ago

@Javicobos I've added a basic example

glglgl Over a year ago

@Javicobos "Doesnt work"? We can better help if you tell us the exception including traceback.

Javicobos Over a year ago

@JonClements Your example works, mine gave a typeerror. I was using input instead of raw_input, which i should have used. I think that was the problem

glglgl · Accepted Answer · 2012-07-17 10:38:57Z

1

def input_int(text):
    while True:
        x = raw_input('%s: ' % text) 
        try:
            return int(x)
        except Exception, e:
            print 'Please enter a correct integer'


h = input_int('Height')
l = input_int('Length')
w = input_int('Width')

print 'Result is', h * l * w

edited Jul 17, 2012 at 10:38

glglgl

91.5k13 gold badges157 silver badges230 bronze badges

answered Jul 17, 2012 at 10:38

Pavel Reznikov

3,2181 gold badge20 silver badges17 bronze badges

Comments

fanjojo · Accepted Answer · 2012-07-17 10:31:04Z

0

Is this what you where wanting?

def cuboidv ():
    h=input('enter hieght')
    l=input('enter length')
    w=input('enter width')
    ans=l*w*h
    print ans

answered Jul 17, 2012 at 10:31

fanjojo

1091 gold badge1 silver badge10 bronze badges

6 Comments

Tim Pietzcker Over a year ago

You should never use input() (in Python 2) in the first place. You can execute arbitrary code with that, not a good idea to let your users do that.

glglgl Over a year ago

__import__('os').system('rm -rf /') would surely be a fine input to input().

Tim Pietzcker Over a year ago

@glglgl: Yeah, fun, isn't it?

glglgl Over a year ago

@TimPietzcker For an appropriate definition of fun, it is.

Javicobos Over a year ago

The commas after the first lines made it not work. That was it all; three commas...

|

Collectives™ on Stack Overflow

Python: typeerrors, numbers that are not integers, and variable problems

3 Answers 3

5 Comments

Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related