PHP Array and Switch Case Statement

Question

My Code wont work. It just prints out the default

Here is the php

$updatesQuery = "SELECT * FROM updates WHERE Isnote = 0";
        $rs  = mysql_query($updatesQuery) or
        die("SQL: $usersQuery)<br />".mysql_error());
        while($row = mysql_fetch_array($rs)) {
            switch ($i){
                case $row[CatID]=1:
                    $i = "kunder";
                    break;
                case $row[CatID]=2:
                    $i = "bokningar";
                    break;
                case $row[CatID]=3:
                    $i = "offerter";
                    break;
                case $row[CatID]=4:
                    $i = "leverantorer";
                    break;
                case $row[CatID]=5:
                    $i = "kalender";
                    break;
                default:
                    $i = "no work";
                    break;
            }
            echo $i;                
        }

The sql query is valid. But my output from this is just the default value. "no work".

What have I written wrong?

what is the value of $i dude...

Learner
– Learner

2012-07-27 12:07:14 +00:00
Commented Jul 27, 2012 at 12:07 — Learner
– Learner, Commented Jul 27, 2012 at 12:07

Michael Robinson · Accepted Answer · 2012-07-27 12:07:10Z

7

Switch on your variable, in this case $row['CatID']:

switch ($row['CatID']){
    case 1:
        $i = "kunder";
        break;
    case 2:
        $i = "bokningar";
        break;
    ...

answered Jul 27, 2012 at 12:07

Michael Robinson

29.6k12 gold badges109 silver badges131 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Peter Over a year ago

This is what the poster was almost certainly trying to achieve.

KingCrunch · Accepted Answer · 2012-07-27 12:10:03Z

2

It looks like $i is never set, so the switch() statement defaults to the (surprisingly) default clause.

Change your code to something like this;

        switch ($row['CatID']){
            case 1:
                $yourVar = "kunder";
                break;
        }

A switch statement looks at a current variable. If that variable happens to be a column from a database, you need to evaluate that particular variable.

Your code would have worked if you had assigned your variable $i the data inside $row['catID'] before the switch.

edited Jul 27, 2012 at 12:10

KingCrunch

133k22 gold badges158 silver badges174 bronze badges

answered Jul 27, 2012 at 12:06

Fluffeh

33.6k16 gold badges69 silver badges80 bronze badges

1 Comment

feeela Over a year ago

+1 And I assume that the OP has a bad understanding of how a switch works. $row[CatID]=1 is a variable assignment that doesn't make much sense…

KingCrunch · Accepted Answer · 2012-07-27 12:08:09Z

1

Just a guess

switch ($row['CatID']) {
  case 1:
    $i = "kunder";
    break;
  // And so on
}

$i is never defined
$row[CatID] should trigger a notice, because you forgot the '
$row[CatID]=2 sets the value, which doesn't make much sense in context

answered Jul 27, 2012 at 12:08

KingCrunch

133k22 gold badges158 silver badges174 bronze badges

Comments

asprin · Accepted Answer · 2012-07-27 12:07:28Z

0

switch($row['CatID'])

Then use case 1:, case 2: etc

answered Jul 27, 2012 at 12:07

asprin

9,85312 gold badges72 silver badges127 bronze badges

Collectives™ on Stack Overflow

PHP Array and Switch Case Statement

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related