Converting array to string looping issue

Question

I have a foreach loop going that is adding e-mail address to an array. At the end I join the array and push it into a string.

I have an issue when someone in the database has a blank email address it messes up my logic. Can someone help me fix this?

TestGuy1: 
TestGuy2: [email protected]
TestGuy3: [email protected]

With the above information it creates a 3 length array and then turns it into a string like so:

sEmailList  "[email protected],[email protected],"  string

Code:

DataTable GetUserReportsToChain = objEmployee.GetUserReportsToChain(LoginID, ConfigurationManager.AppSettings.Get("Connection").ToString());

int RowCount = GetUserReportsToChain.Rows.Count;
string[] aEmailList = new string[RowCount];
int iCounter = 0;
foreach (DataRow rRow in GetUserReportsToChain.Rows)
{
    if (rRow["usrEmailAddress"].ToString() != "")
    {
        aEmailList[iCounter] = rRow["usrEmailAddress"].ToString();
        iCounter++;
        //String email = rRow["usrEmailAddress"].ToString(); 
    }
}

string sEmailList = String.Join(",", aEmailList);

Any idea how I can fix this when the database has a blank value for e-mail?

Please provide "expected" value. Also I see nothing particularly wrong about your string - just make code that uses it resilient to empty elements. — Alexei Levenkov
– Alexei Levenkov, Commented Aug 28, 2012 at 19:01
When rRow["usrEmailAddress"].ToString()=="" is true then there are empty slots in aEmailList not set to an email address. — L.B
– L.B, Commented Aug 28, 2012 at 19:05

Raphaël Althaus · Accepted Answer · 2012-08-28 19:13:20Z

4

All in one

var sEmailList = String.Join(",", 
      GetUserReportsToChain.Rows
      .Cast<DataRow>()
      .Select(m => m["usrEmailAddress"].ToString())
      .Where(x => !string.IsNullOrWhiteSpace(x)));

edited Aug 28, 2012 at 19:13

answered Aug 28, 2012 at 19:08

Raphaël Althaus

60.6k6 gold badges106 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

L.B Over a year ago

Cast<DataRow> ==> Cast<DataRow>()

Raphaël Althaus Over a year ago

@JamesWilson : all but first:

DataTable GetUserReportsToChain = objEmployee.GetUserReportsToChain(LoginID, ConfigurationManager.AppSettings.Get("Connection").ToString());

Raphaël Althaus · Accepted Answer · 2012-08-28 20:10:54Z

4

You want to use List<string> instead of fixed size array. Or simple LINQ query that returns non-empty strings.

List<string> aEmailList = new List<string>();
foreach (DataRow rRow in GetUserReportsToChain.Rows)
{
    if (!String.IsNullOrEmpty(rRow["usrEmailAddress"].ToString()))
    {
        aEmailList.Add(rRow["usrEmailAddress"].ToString());
    }
}
string sEmailList = String.Join(",", aEmailList);

edited Aug 28, 2012 at 20:10

Raphaël Althaus

60.6k6 gold badges106 silver badges127 bronze badges

answered Aug 28, 2012 at 19:02

Alexei Levenkov

101k15 gold badges138 silver badges189 bronze badges

3 Comments

James Wilson Over a year ago

Ok I am going to try and implement this solution.

James Wilson Over a year ago

It gives me this error on your very first line above. Error 1 'System.Collections.Generic.List<string>' is a 'type' but is used like a 'variable'

Kevin Over a year ago

Needs the new keyword: List<string> aEmailList = new List<string>();

Aghilas Yakoub · Accepted Answer · 2012-08-28 19:03:11Z

2

you can try with

String.Join(",", aEmailList.Where(s => !string.IsNullOrEmpty(s)));

answered Aug 28, 2012 at 19:03

Aghilas Yakoub

29k5 gold badges49 silver badges51 bronze badges

Comments

TalonMcShay · Accepted Answer · 2012-08-28 19:06:25Z

2

You can change your if statement to:

if(!string.IsNullOrEmpty(rRow["usrEmailAddress"].ToString().Trim())

answered Aug 28, 2012 at 19:06

TalonMcShay

3163 silver badges9 bronze badges

Comments

Brian Warshaw · Accepted Answer · 2012-08-28 19:03:24Z

0

If you're using 3.0 or higher:

String.Join(",", aEmailList.Where(s => s.Trim() != ""));

answered Aug 28, 2012 at 19:03

Brian Warshaw

23k9 gold badges55 silver badges72 bronze badges

2 Comments

Servy Over a year ago

This needs 4.0 to compile, not 3.0

Brian Warshaw Over a year ago

Right you are. For 3.0, you would have to convert the result of "Where" with "ToArray".

Collectives™ on Stack Overflow

Converting array to string looping issue

5 Answers 5

2 Comments

3 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

2 Comments

3 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related