Android string works from code but crashes from string.xml

Question

I have following code:

String personalinfos[] = {"Age", "Gender", "Height", "Weight"};
@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.myLayout);

setListAdapter(new ArrayAdapter<String>(Screening.this, android.R.layout.simple_list_item_1, personalinfos));

And it works, it does it's job. But as I need to do internationalized / localized project, I'm moving it to strings.xml, so I've added this to strings.xml

<string-array name="my_keys">
    <item>Age</item>
    <item>Gender</item>
    <item>Height</item>
    <item>Weight</item>
</string-array>

And tried to change code into:

String personalinfos[] = getResources().getStringArray(R.array.my_keys);

Assuming that I'll get same result, but I don't, my app crashes.

So question here:

What's the proper way to read string-array from strings.xml?

I do not understand why it crashes.

Try to declare your personalinfos[] as Global variable and initialize it. — Praveenkumar
– Praveenkumar, Commented Aug 31, 2012 at 13:26
Make sure you're calling getResources().getStringArray(R.array.my_keys); in the onCreate. You can't call getResources() before your activity class is instantiated — Mario
– Mario, Commented Aug 31, 2012 at 13:26

Community · Accepted Answer · 2017-05-23 11:49:06Z

1

Just try like this -

String personalinfos[];
@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.myLayout);

    personalinfos = getResources().getStringArray(R.array.my_keys);

setListAdapter(new ArrayAdapter<String>(Screening.this, android.R.layout.simple_list_item_1, personalinfos));

Read your related one - Help in getting String Array from arrays.xml file

edited May 23, 2017 at 11:49

CommunityBot

11 silver badge

answered Aug 31, 2012 at 13:29

Praveenkumar

24.6k23 gold badges101 silver badges177 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Balkyto Over a year ago

Hi, the related link helped + combination of Berťák answer to create a String list.

Berťák · Accepted Answer · 2012-08-31 13:30:21Z

0

try to define your strings one by one in strings.xml, then define your items in array like:

<item>@string/string_identifier</item>

is it working?

more info about strings and string arrays here

answered Aug 31, 2012 at 13:30

Berťák

7,3572 gold badges35 silver badges39 bronze badges

Comments

RossC · Accepted Answer · 2012-08-31 13:28:57Z

0

Have you tried:

Resources res = getResources();
String[] personalinfos = res.getStringArray(R.array.my_keys);  // no []

Documentation here: http://developer.android.com/guide/topics/resources/string-resource.html

answered Aug 31, 2012 at 13:28

RossC

1,2302 gold badges13 silver badges26 bronze badges

Comments

Enrichman · Accepted Answer · 2012-08-31 13:38:03Z

0

1) POST THE LOGCAT. That's why it crashes.

2) What about creating an array.xml file with your arrays and call them directly from your xml?

So create your array.xml and define it like:

<resources>
    <string-array name="array">
        <item>A</item>
        <item>B</item>
    </string-array>
</resources>

and then in your layout use the entries property:

<ListView
    android:layout_width="fill_parent"
    android:layout_height="fill_parent"
    android:entries="@array/array"/>

answered Aug 31, 2012 at 13:38

Enrichman

11.3k11 gold badges69 silver badges102 bronze badges

Comments

Variag · Accepted Answer · 2017-12-18 09:59:44Z

0

You can't use getResources() outside any activity/fragment lifetime methods. The resources are not yet ready when you try to access them in your class. To do it properly define your variable anywhere you want and initialize it in onCreate() or onCreateView() methods. See Praveenkumar answer for a simple example.

answered Dec 18, 2017 at 9:59

Variag

1,09510 silver badges26 bronze badges

Collectives™ on Stack Overflow

Android string works from code but crashes from string.xml

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related