Adding Multiple inline javascript in single line

Question

I have 2 different links with inline js added.

I would like to add both to a single inline onclick.

Here are the two separate one:

<a href="#" onclick=\'$("#id").toggle();\'>

<a href="#" onclick="myvar = '1';">

And this is what I would like to do:

<a href="#" onclick="$("#id").toggle();myvar = '1';">

How could I do this?

You want this ? <a href="#" onclick="$('#id').toggle();myvar = '1';">. Did you see you have problems with quotes ? — Denys Séguret
– Denys Séguret, Commented Sep 25, 2012 at 13:24
What actually are you trying to do? Why do you separate JavaScript code into several inline event handlers? — VisioN
– VisioN, Commented Sep 25, 2012 at 13:24
Just write this: <a href="#" onclick="$('#id').toggle();myvar = '1';"> — Sebastian Breit
– Sebastian Breit, Commented Sep 25, 2012 at 13:25
First of all: there's no jQuery in here. And second: don't do this. Separate your HTML and the client code. Bind event handlers not in the HTML. You'll thank me. — user659025
– user659025, Commented Sep 25, 2012 at 13:26
I could answer the question by telling you to escape the quotes in $("#id"), but that would mean that you'd continue to use inline javascript, which is pretty much always the wrong approach. — zzzzBov
– zzzzBov, Commented Sep 25, 2012 at 13:27

NullPoiиteя · Accepted Answer · 2012-09-25 13:27:30Z

6

you can use

$("a").click(function(){
   $('#id').toggle(); myvar = '1';
 })

answered Sep 25, 2012 at 13:27

NullPoiиteя

57.3k23 gold badges130 silver badges148 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

jbabey · Accepted Answer · 2012-09-25 13:25:39Z

4

Attach your event handlers in javascript (why?), then it becomes trivial:

HTML:

<a href="#" id="myAnchor" />

JS:

document.getElementById('myAnchor').onclick = function () {
    $("#id").toggle();
    myvar = '1';
};

answered Sep 25, 2012 at 13:25

jbabey

46.8k12 gold badges73 silver badges94 bronze badges

Comments

Reinstate Monica Cellio · Accepted Answer · 2012-09-25 13:25:30Z

3

Exactly like you have, but with syntax errors fixed...

<a href="#" onclick="$('#id').toggle(); myvar = '1';">

Incidentally, be ready for a slew of people telling you not to use inline code.

answered Sep 25, 2012 at 13:25

Reinstate Monica Cellio

26.2k6 gold badges54 silver badges67 bronze badges

3 Comments

Satch3000 Over a year ago

I don't use inline frequently but in this case I want to though :)

Reinstate Monica Cellio Over a year ago

@dystroy - please don't judge people by your own standards. I posted this answer before your comment, but you don't see me accusing you of foul play.

Reinstate Monica Cellio Over a year ago

@Satch3000 - I understand. You do it the way you want to do it, that's why I answer your question as asked :)

StaticVariable · Accepted Answer · 2012-09-25 13:26:28Z

2

simply use this

$("a").click(function(){

$("#id").toggle(); myvar = '1';

 })

answered Sep 25, 2012 at 13:26

StaticVariable

5,2934 gold badges26 silver badges46 bronze badges

Comments

FrankieTheKneeMan · Accepted Answer · 2012-09-25 13:25:56Z

1

... You did it, basically. You just have to unify how you're declaring your strings and you're all set:

<a href="#" onclick="$('#id').toggle();myvar = '1';">

Voila.

answered Sep 25, 2012 at 13:25

FrankieTheKneeMan

6,8082 gold badges29 silver badges39 bronze badges

4 Comments

Denys Séguret Over a year ago

I didn't downvote but this comes a few minutes after comments and answers already saying it.

freakish Over a year ago

+1 ( because of down vote ). Technically it does answer the question. However it is a bad practice to keep HTML and JavaScript not separated.

Satch3000 Over a year ago

It might now be best practice but totally legal so why not use it? :)

FrankieTheKneeMan Over a year ago

Because people are under the mistaken impression that if you don't put any JS tags in your HTML, that will somehow make it totally independant of the JS attached to it. Never mind that most applications are inexorably tied to the JS behind them, and using onClick to call functions will not only make the purpose of the page more clear while reading just the HTML. Additionally, the premise is flawed because people love to assign a unique ID to every element and then use $('#id').click(dosomething); Meaning the html and JS are now tied in the far more reusable section of the code.

Tarman · Accepted Answer · 2012-09-25 13:28:05Z

1

Can't you just do what you are doing in javascript?

$(document).ready(function(){
    $('#id').toggle(function(){
        myVar = 1;
    });
});

... or something.

answered Sep 25, 2012 at 13:28

Tarman

462 bronze badges

Collectives™ on Stack Overflow

Adding Multiple inline javascript in single line

6 Answers 6

Comments

Comments

3 Comments

Comments

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

3 Comments

Comments

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related