why doesn't my file upload script work?

Question

Do you see what's wrong here? I can't find anything.

this prints:

echo $_FILES["new_text_file"]["name"];

and this too:

echo $_FILES["new_text_file"]["tmp_name"];

php:
"; echo $_FILES["new_text_file"]["tmp_name"]; //Uploads the text file to the server

        if(move_uploaded_file($_FILES["new_text_file"]["tmp_name"]), $_FILES["new_text_file"]["name"]) 
        {
            //header('Location: ga-dev-exercise-pavan.php');
            echo 'worked';
        }else {
            echo 'did not work';
        }
}
?>

html:

    <form enctype="multipart/form-data" action="ga-dev-exercise-pavan.php" method="POST">
        Choose a text file you want to upload and search through: 
        <input type='file' name='new_text_file'>

        <input type="hidden" name="submit_yes_file" value="true" />
        <br /><br />
        <input type="submit" value="upload">
    </form>

Move the file to another folder. You're currently leaving it in the tmp folder — Bgi
– Bgi, Commented Nov 2, 2012 at 18:26
Use method=GET so you can see what's going inside the parameters. It might help you find out where your error is. — user1534664
– user1534664, Commented Nov 2, 2012 at 18:27
Do: var_dump($_FILES); to see the complete information inside the variable and be sure that is not a typo on the key names. — slash28cu
– slash28cu, Commented Nov 2, 2012 at 18:28
@user1534664 not recommended on production and potentially hard to switch from (can be anticipated) — John Dvorak
– John Dvorak, Commented Nov 2, 2012 at 18:28
@JanDvorak true. I only recommend it for now because he can't find his error, and often it might turn out that the parameters are empty or stuff like that. — user1534664
– user1534664, Commented Nov 2, 2012 at 18:33

LSerni · Accepted Answer · 2012-11-02 18:31:04Z

2

You aren't automatically allowed to move the uploaded file everywhere. You need to move it somewhere your PHP script has permissions to write.

So e.g.

$src = $_FILES["new_text_file"]["tmp_name"];
$dst = './tmp_dir/'.basename($_FILES["new_text_file"]["name"]);

if (move_uploaded_file($src, $dst))
{

The basename protects you against the user specifying malicious file paths (does nothing against duplicate file names), the tmp_dir is a directory you can write to.

Using $src and $dst clears a bit the code, and allowed me to see that you had an extra parenthesis in your sample...

answered Nov 2, 2012 at 18:31

LSerni

57.7k10 gold badges70 silver badges110 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pavan Katepalli Over a year ago

Thanks Iserni. I figured out the issue below. It was the parentheses.

Shahrokhian · Accepted Answer · 2012-11-02 20:19:28Z

2

you should specify a target path

$target_path = "uploads/";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); 

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['uploadedfile']['name']). 
    " has been uploaded";
} else{
    echo "There was an error uploading the file, please try again!";
}

http://www.tizag.com/phpT/fileupload.php

Edit : as mentioned in comments , parentheses are misplaced :

wrong :

if(move_uploaded_file($_FILES["new_text_file"]["tmp_name"]), $_FILES["new_text_file"]["name"])

correct

if(move_uploaded_file($_FILES["new_text_file"]["tmp_name"], $_FILES["new_text_file"]["name"]))

edited Nov 2, 2012 at 20:19

answered Nov 2, 2012 at 18:28

Shahrokhian

1,11413 silver badges28 bronze badges

1 Comment

Pavan Katepalli Over a year ago

thanks RezaSh. The issue was the parentheses. I submitted an answer below. I needed the file to be uploaded into the current directory, so that's why I didn't specify a sub directory.

Pavan Katepalli · Accepted Answer · 2012-11-02 20:10:39Z

1

The parentheses were off. It should be like this:

if(move_uploaded_file($_FILES["new_text_file"]["tmp_name"], $_FILES["new_text_file"]["name"]))

answered Nov 2, 2012 at 20:10

Pavan Katepalli

2,4644 gold badges33 silver badges52 bronze badges

Collectives™ on Stack Overflow

why doesn't my file upload script work?

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related