Passing an array from controller to model in codeigniter

Question

I am trying to pass an array through a function in a controller class and retrieve it from another function in a class inside model, but the values cannot be retrieved. please advise.

The code is as follows.

Controller class code

 class home extends CI_Controller {

function __construct() {
    parent::__construct();
    $this->load->helper('url');
}

function index() {
    $this->load->view('loginview');
}

function login() {
    $parameters = array(
        '$uname' => $this->input->post('uname'),
        '$passwords' => $this->input->post('password')
    );

    $this->load->model('loginModel');
    $validate = $this->loginModel->validateuser($parameters);

    if(count($validate)== 1){
        echo "Logged in";
    }
    else
    {
        //redirect('home/index');
        echo "dasad";
    }


}

}

Model class code

class loginModel extends CI_Model {

function __construct() {
    parent::__construct();
}

public function validateuser($parameters) {

        $uname = $parameters['uname'];
        $pass = sha1($mem['pass']);



    $query = $this->db->query("select * from user where username = '$uname' and password = '$pass'");
    $result = $query->result_array();
    return $result;

}

}

The variables $uname and $pass are the two values that need to get to query the database. please help

Possible duplicate of Pass an array from controller to model in codeigniter — Amaan Iqbal
– Amaan Iqbal, Commented Jul 1, 2017 at 17:29

aykut · Accepted Answer · 2012-11-15 12:19:01Z

1

There are errors in your code. Correct ones of controller login() method:

function login() {

    // you don't need '$' sign
    $parameters = array(
        'name' => $this->input->post('uname'),
        'pass' => $this->input->post('password')
    );

    $this->load->model('loginModel');
    $validate = $this->loginModel->validateuser($parameters);

    // stuff..

}

and model loginModel() method:

public function validateuser($parameters) {

    $uname = $parameters['name'];
    $pass = sha1($parameters['pass']); // and second error was here

    // stuff..

}

answered Nov 15, 2012 at 12:19

aykut

3,1021 gold badge28 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Orin12 Over a year ago

owh.... ya thanks a lot i have used $ in array keys in the controller that s the biggest problem thanks again...

Abdul Haseeb · Accepted Answer · 2012-11-15 12:21:19Z

1

Your array key strings are different in model and controller classes. Here are the possible fixes.

In Controller use this:

$parameters = array(
        'uname' => $this->input->post('uname'),
        'passwords' => $this->input->post('password')
    );

Secondly in your Model. Use this to get parameters.

  $uname = $parameters['uname'];
  $pass = sha1($parameters['passwords']);

Hope it helps.

answered Nov 15, 2012 at 12:21

Abdul Haseeb

5584 silver badges14 bronze badges

2 Comments

Rick Calder Over a year ago

This doesn't matter with the way the variables are being passed.

Orin12 Over a year ago

yes, using $ in array keys was the biggest problem and ya it was nt matching as well thanks a lot for the help....

Sachin Prasad · Accepted Answer · 2012-11-16 08:45:49Z

0

I see your answer is already fixed but i just want to give you an alternative of doing it. It is more secure and short:

Controller:

function login() {

    $this->load->model('loginModel');
    $validate = $this->loginModel->validateuser();

    if($validate ){
        echo "Valid User";
    } else{
        echo "Invalid User";
    }
}

Model:

public function validateuser() {

 $query = $this->db->query("select * from user where username = ? and password = ?",array($this->input->post('uname'),sha1($this->input->post('password'))));
   if($query->num_rows() == 1){
      return true;
   }else{
     return false;
  }

}

answered Nov 16, 2012 at 8:45

Sachin Prasad

5,37212 gold badges56 silver badges101 bronze badges

1 Comment

Orin12 Over a year ago

yes, it was solved. looks like your methods is better from what i have done... thanks alot for the suggestion.

pollux1er · Accepted Answer · 2020-04-05 19:46:28Z

0

I had the same issue and the only way to do this I found obviously was to json_encode() the array in the controller and json_decode them in the model. IT worked like a charm form me. Good luck!

answered Apr 5, 2020 at 19:46

pollux1er

5,9895 gold badges41 silver badges38 bronze badges

Collectives™ on Stack Overflow

Passing an array from controller to model in codeigniter

4 Answers 4

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related