class to create objects from another class, but with less overhead

Question

What I am trying to do is write a "search" class that can search for a list of products and store them in an array.

I already have a "product" class that can be used to get the details of a specific product.

Here is my code:

class Product {

    public $name;
    public $price;
    public $description;

    public function getProductById ($id) {

        $sql = 'SELECT name, price, description FROM product WHERE id = ' . $id;

        $row = /* MySQL functions here to execute SQL statement and get a matching row */

        $this->name = $row['name'];
        $this->price = $row['price'];
        $this->description = $row['description'];
        return TRUE;
    }
}

class Search {

    public $results;
    public $totalResults;

    function __construct() {
        $this->results = array ();
        $this->totalResults = 0;
    }

    public function doSearch ($name) {

        $sql = 'SELECT id FROM product WHERE name LIKE "%' . $name . '%"';

        $rows = /* MySQL functions here to execute SQL statement and get a list of matching product ID's */

        foreach ($rows as $row) {
            $product = new Product;
            $product->getProductById ($row['productid']);
            $this->results[] = $product;
        }
        return TRUE;
    }
}

$search = new Search;
$search->doSearch ('Fresh Flowers');

The problem with the above is that every matching record in the doSearch method will execute a query in the getProductById method. If there are 100 matching products, there will be 100 individual queries carried out in the Product class.

However, if I get the products directly in the doSearch method using a single query, this will then bypass the Product class altogether.

When a "product" is an object, what's the most appropriate way to write a search class that can return a list of "product" objects without the overhead of what I'm doing above?

oh, i didnt notice the same table was being used in both queries. — goat
– goat, Commented Nov 24, 2012 at 19:10

Wolfgang Stengel · Accepted Answer · 2012-11-24 19:11:01Z

1

Add a constructor to the Product class which takes name, price and description as parameters (or an assoziative array), to populate the object with the necessary values, decoupled of the database query.

Within doSearch, you can then create a SELECT which not only gets the ID but all relevant fields from the products table, and create the populated product objects immediately with new Product($name, $price, $description) or new Product($row), without calling getProductById for each product.

edited Nov 24, 2012 at 19:11

answered Nov 24, 2012 at 19:04

Wolfgang Stengel

2,8561 gold badge19 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

phant0m · Accepted Answer · 2012-11-24 19:02:09Z

0

Create a class that populates instances of Product with data from the database.

The class can then create one or multiple instances of the Product class depending on how much data is being fetched.

Conclusion: Extract the getProductById from your Product class and put it somewhere else. It is a specialised method that only populates one instance.

answered Nov 24, 2012 at 19:02

phant0m

17k6 gold badges52 silver badges84 bronze badges

Comments

Community · Accepted Answer · 2017-05-23 11:48:56Z

0

Just grab what you want in the first place.

public function doSearch ($name) {

        $sql = 'SELECT id, name, price, description FROM product 
           WHERE name LIKE "%' . $name . '%"';

// now just return the array    

}

Or use PDO to return result sets as objects.

$result->setFetchMode(PDO::FETCH_INTO, new animals);

as discussed here: How can I simply return objects in PDO?

edited May 23, 2017 at 11:48

CommunityBot

11 silver badge

answered Nov 24, 2012 at 19:19

Cups

6,9063 gold badges29 silver badges30 bronze badges

Comments

Sven · Accepted Answer · 2012-11-24 19:54:46Z

0

Your Product class shouldn't know anything about a database. It should contain the values representing a product, nothing more. Extract all stuff dealing with the database out of this class.

Searching for products is one way to access a list of products. Your next class should be a list of products then. Only when accessing one single product you'd not have to deal with a list, but this is probably less often than you think.

Ok, you have the product and the list of products, you now can go one step forward and add database access. You need a class that deals with giving you both one product (when searching by id) and lists of products (when searching by some text or other stuff). Only this class allows you to deal with the queries needed to access the database. The result sets of each query may directly be used inside the "list of products" class, probably by inheriting all the stuff that is defined in the general "list of products" class and adding dealing with database results.

So in the end you'll end up having:

Product -> ListOfProducts -> ProductDatabase -> DatabaseAccessLayer

answered Nov 24, 2012 at 19:54

Sven

71.2k10 gold badges113 silver badges113 bronze badges

1 Comment

MrCarrot Over a year ago

I marked Wolfgang Stengel's answer as the correct one as it gave the most direct answer to the example given. I tried what you are suggesting and couldn't quite get my head around it, but that's probably down to my level of expertise. I see where you're coming from though and would like to experiment with your idea further.

Collectives™ on Stack Overflow

class to create objects from another class, but with less overhead

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related