Insert multiple same named fields into MySQL Database using PHP

Question

I have multiple fields with names that look like name_$i and I am trying to figure out a way to "on submit", send them all to the database. The thing is that the form is looped and the insert has to be able to adapt to the number of fields in the form. Is there a way to do this???

<?php

$fldcnt = $_POST['fldcnt'];
$i = $_POST['i'];

for ($i = 0; $i < $fldcnt; $i++){
$NAME = $_POST['name_$i'];
$AGE = $_POST['age_$i'];
$ADDRESS = $_POST['address_$i'];
$TELEPHONE = $_POST['telephone_$i'];
$EMAIL = $_POST['email_$i'];



$q_register_new_users = "insert into registration set
        NAME = '$NAME',
        AGE = '$AGE',
        ADDRESS = '$ADDRESS',
        TELEPHONE = '$TELEPHONE',
        EMAIL = '$EMAIL'";

    mysql_query($q_new_products,$connection) or die(mysql_error());


};
?>"

Use arrays for the name field instead of name_$1 then you can loop through them easily — Ben Carey
– Ben Carey, Commented Dec 11, 2012 at 13:37
The variables you're building, aren't those the field names? And are you getting any errors? — Mike Perrenoud
– Mike Perrenoud, Commented Dec 11, 2012 at 13:38
Using array is best way to do this. But if you still want to go head with a counter then you could use for($i = 0;isset($_POST["name_{$i}"]);$i++){...} — shawndreck
– shawndreck, Commented Dec 11, 2012 at 13:39
@shawndreck don't post answers as comments. Post answers as answers... — Cylindric
– Cylindric, Commented Dec 11, 2012 at 14:41

Ben Carey · Accepted Answer · 2012-12-11 14:23:37Z

2

HTML and PHP

You can enter input fields into an array by simply calling the field name[]. Like so:

<input name="name[]" />

You can then use PHP to loop through the fields like so:

foreach($_POST['name'] as $key=>$value){
    // Insert the value of the form field into a string or query
    // i.e. build the query
    $query .= $value;
}

// Then execute the query for each set of fields

The logic above is actually incorrect, but it should give you an idea of what I mean.

MySQL

Your SQL syntax is incorrect, the correct syntax for inserting into a MySQL database is:

INSERT INTO `table` (`field_1`, `field_2`)
VALUES ('value_1', 'value_2')

PLEASE NOTE

The use of the mysql_ functions is hugely discouraged due to there impending deprecation. Instead, most PHP programmers are now using the PDO / SQLite Classes. Whilst these might seem complex, they are actually pretty simple and offer a much more secure way of executing SQL statements.

PDO
SQLite

edited Dec 11, 2012 at 14:23

answered Dec 11, 2012 at 13:45

Ben Carey

17k20 gold badges95 silver badges181 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Cylindric Over a year ago

+1 for recommending PDO. Going to take a long time for mysql_* to die :(

Ben Carey Over a year ago

@Cylindric That is true, am still trying to encourage as many people as possible to migrate to it. Once the migration is done, it is so much better and so much easier. :-)

Community · Accepted Answer · 2017-05-23 12:03:53Z

0

The syntax for INSERT statement should be like this,

 INSERT INTO registration (NAME , AGE , ADDRESS, TELEPHONE, EMAIL)
 VALUES ('$NAME', '$AGE', '$ADDRESS','$TELEPHONE', '$EMAIL')

but hte query above is vulnerable with SQL INJECTION, please read the article below to learn how to protect from it,

How can I prevent SQL injection in PHP?

edited May 23, 2017 at 12:03

CommunityBot

11 silver badge

answered Dec 11, 2012 at 13:38

John Woo

265k70 gold badges509 silver badges500 bronze badges

Comments

jcjr · Accepted Answer · 2012-12-11 14:01:06Z

0

If you are going to keep structure of your code, you need to use double quotes instead of apostrophes

$NAME = $_POST["name_$i"];

or put the variable out

$NAME = $_POST['name_'.$i];

edited Dec 11, 2012 at 14:01

answered Dec 11, 2012 at 13:46

jcjr

1,50125 silver badges40 bronze badges

3 Comments

jcjr Over a year ago

$i=1; echo 'name_$i'; echo "name_$i"; >> name_$i name_1

Ben Carey Over a year ago

That was not very clear in your answer, it seemed that you were stating that he shouldn't do the above, he should do the second. Have removed the downvote as it is now clearer what you intended

jcjr Over a year ago

I tried to improve the post, hoping it is more clear now. Anyway, I agree that using arrays is better aproach, but my idea seems like a good quick fix

shawndreck · Accepted Answer · 2012-12-15 19:36:16Z

0

Using array is best way to do this. But if you still want to go head with a counter then you could use

for($i = 0;isset($_POST["name_{$i}"]);$i++)
{
 // name found
}

Please note that this code may not be optimal if the name_xx fields are coming from checkboxes, where a user selected items and skipped some in between.

PS. I posted this a comment but it is more suitable as an answer.

answered Dec 15, 2012 at 19:36

shawndreck

2,0691 gold badge25 silver badges31 bronze badges

Collectives™ on Stack Overflow

Insert multiple same named fields into MySQL Database using PHP

4 Answers 4

HTML and PHP

MySQL

2 Comments

Comments

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

HTML and PHP

MySQL

2 Comments

Comments

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related