How can i write a insert statement in ruby on rails?

Question

I run a insert statement on ruby on rails. But failed. This is the code:

class BookmarkController < ApplicationController
  def index

    if request.post?
    @user_new = Bookmark.new(params[:user_new])
    tags = @user_new.tags.split(",")
    @user_new = Bookmark.new(params[:user_new])
    query = "INSERT INTO bookmark (title , url, tags) VALUES (#{@user_new.title}, #{@user_new.url}, #{tags[0]})  "

    Bookmark.connection.execute(query);

    end   

  end

But the output is :

ActiveRecord::StatementInvalid in BookmarkController#index

SQLite3::SQLException: near ".": syntax error: INSERT INTO bookmark (title , url, tags) VALUES (abhir, www.mrabhiram.tumblr.com, tumblr)

Can anyone suggest me the proper way to insert records using SQL insert statement?

Raw SQL should never be in the controller. Also, you're duplicating functionality that comes with ActiveRecord. I recommend reading the ActiveRecord guide. — Mark Thomas
– Mark Thomas, Commented Dec 13, 2012 at 10:26

Scott S · Accepted Answer · 2012-12-12 18:04:15Z

2

Assuming Bookmark is subclassed from ActiveRecord, AR will save this for you - no need to write custom SQL - the save method will take care of this. You can read more about relevant ActiveRecord functionality here

class BookmarkController < ApplicationController
  def index

    if request.post?
    @user_new = Bookmark.new(params[:user_new])
    tags = @user_new.tags.split(",")
    @user_new = Bookmark.new(params[:user_new])
    #query = "INSERT INTO bookmark (title , url, tags) VALUES (#{@user_new.title}, #{@user_new.url}, #{tags[0]})  "

    #Bookmark.connection.execute(query);
    # The save method will insert the record into the database.
    @user_new.save()    

    end   

  end

answered Dec 12, 2012 at 18:04

Scott S

2,73618 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mandeep Singh · Accepted Answer · 2014-01-31 06:48:58Z

2

You can write

    MOdel.connection.insert("INSERT INTO table_name(fields) VALUES('value')")

it's working...

answered Jan 31, 2014 at 6:48

Mandeep Singh

1,0039 silver badges9 bronze badges

1 Comment

Ganga Over a year ago

@Mandeep_Singh how do we commit/ save this insertion?

Michael Durrant · Accepted Answer · 2012-12-12 17:45:41Z

0

You need quotes on your 'values' data. Something like:

query = "INSERT INTO bookmark (title , url, tags) VALUES ('#{@user_new.title}', '#{@user_new.url}', '#{tags[0]}')  "

answered Dec 12, 2012 at 17:45

Michael Durrant

97.2k102 gold badges352 silver badges536 bronze badges

2 Comments

Simon Perepelitsa Over a year ago

Don’t use this code! It is a classic example of SQL injection. Your users will be able to execute arbitrary SQL commands on your database.

bigtex777 Over a year ago

This answer will work here and is correct syntax, but as mentioned, you wouldn't want to do it here because it is unsafe and there are much better Rails ways to accomplish the same thing.

Collectives™ on Stack Overflow

How can i write a insert statement in ruby on rails?

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related