javascript dropdown menu onclick

Question

I've been working at this for a while now, but don't understand what's wrong with my code. I'm sure it's something simple - it always is!

Basically, I have a drop down menu, with some options. I want it to go to a web page when the third option, plumber, is selected. When any of the others are clicked, nothing should happen.

My code so far is:

<select id = 'search'>
<option value="1">Carpenter</option>
<option value="2">Electrician</option>
<option value="3">Plumber</option>
<option value="4">Tiler</option>
<option value="5">Boiler Installation</option>

</select>

Go

And my javascript is:

<script>
function go_button {
if (search.value=="3") {
location="search_results.htm"
}
}

</script>

But it's not working. Could someone tell me what's wrong?

Thanks.

C.

ddev · Accepted Answer · 2012-12-18 12:06:09Z

5

You can either put a change event on your control via script or add it directly to your control..

Direct Method:

<select id="search" onChange="OnSelectedIndexChange()">

This is the function you need to put in your Script:

//function for changed selection
function OnSelectedIndexChange()
{
if (document.getElementById('search').value == "3"){
    location.href="search_results.htm";
}
}

Add Change event using Script (either JavaScript or JQuery):

I suggest JQuery for doing so (the onSelectedIndexChange function is obsolete here)

$('#search').change( function() {

if(this.val() == "3"){
location.href="search_results.htm";
}

});

If you don't want to use JQuery just add the following code:

    var yourdropdown = document.getElementById('search');
    yourdropdown.Attributes.Add("onChange", "return OnSelectedIndexChange();")

edited Dec 18, 2012 at 12:06

answered Dec 18, 2012 at 11:45

ddev

3892 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jon Taylor · Accepted Answer · 2012-12-18 11:38:27Z

0

You need to tell javascript which element it is you are interested in.

Use getElementById("search") to return the element then you can look into getting its value.

answered Dec 18, 2012 at 11:38

Jon Taylor

7,9255 gold badges32 silver badges55 bronze badges

Comments

s-m-e · Accepted Answer · 2012-12-18 11:44:30Z

0

<select id="search">

I think, there are to many spaces.

getElementById("search").value

I have not used this in a while, but is not it ...

location.href = "search_results.htm";

Somewhat like this gives you access to the object. And last but not least, you need to associate your function "go_button" with an event of the drop down box, something like this:

<select id="search" onClick="go_button();">

answered Dec 18, 2012 at 11:44

s-m-e

3,7892 gold badges43 silver badges82 bronze badges

Comments

huncyrus · Accepted Answer · 2012-12-18 11:54:29Z

0

I think - if possible - use jQuery or other js framework, both have built-in select and other html/dom plugins & methods.

answered Dec 18, 2012 at 11:54

huncyrus

6589 silver badges18 bronze badges

Collectives™ on Stack Overflow

javascript dropdown menu onclick

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related