0

This is my current system for a framework that I'm making:

I create an object upon a request to access a non-existing property, that has the name of an existing class through the __get function defined in the Core class. The Core class extends every class.

So it works like this:

class Someclass extends Core
{
    public function classmethod()
    {
        $this->otherclass->method();
    }
}

This works exactly how I want it to work. However, I have no idea (after a lot of frustration) how to edit/create properties of the object, using this system.

So something like this would't work.

$this->view->somevar = "newvalue"; // this doesn't work.

I guess it has to do something with the __set function, but I failed to find out.

I received the following suggestions how to tackle this problem:

Dependency injection, Namespaces, Singleton pattern.

I would love to see how to implement what I'm trying to do using one of these patterns.

I have no idea which to choose in order to achieve my simple problem: Use objects in other classes, so i don't need to put anything into __construct's parameters or using global variables.

I am using __autoload.

I hope i can tackle this problem with your help.

Improve this question
6
  • 1
    greetings, this and your other questions suggest you are making a framework with many similarities to codeigniter. I realize this doesn't directly answer your question, but have you checked out codeigniter source code? github.com/EllisLab/CodeIgniter, code igniter is a very popular project and they do some of the Exacgt things you are asking in your questions. Commented Dec 30, 2012 at 15:12
  • @dm03514 Indeed, my goal is something similar to codeigniter, but simpler and lighter. I am hoping to learn a lot in the process. Thank you, I will check the source out! The problem is, I am in a great time shortage, that is the reason of me asking these questions. Commented Dec 30, 2012 at 15:16
  • @Rasteril, why wouldn't this: $this->view->somevar = "newvalue"; work? Commented Dec 30, 2012 at 15:28
  • I guess it has to do something with the __set function .. well you guessed right, I don't see any implementation code of the classes you are calling, would be helpful to see how you implemented the __set method and/or how it gets inherited. Commented Dec 30, 2012 at 15:33
  • @Rasteril you could also take a look at Silex, a PHP micro-framework with encompasses some newer PHP development concepts Commented Dec 30, 2012 at 15:45

1 Answer 1

Reset to default
2

First of all, the architecture you're attempting is extremly bad. Aparently you are using "magic" to create objects attached as properties to other objects. Which is bad, because if you use _get/_set, you will end up in problems sooner rather than later. Also extending from a common parent is a bad thing because it generates huge inheritance trees, and it allows most of the objects to have more than one responsability.

Before starting a framework, you might want to look over: SOLID

Now coming back to your question, if you use __get for getting a value, you can as well use __set for setting a value.

__construct method is there in order to allow you to initialize the object with all the data it needs in order to fulfill his sole purpose. Avoiding the __construct is kinda stupid, and defeats the purpose. You might want to pay attention to the D in SOLID in order to see what Dependency Inversion really is and to understand it.

Using __set loses completely the ability to typehint interfaces and so on. Therefore the code can become really buggy and ijcredibly hard to follow, since the flow is not so well defined, and the allocation is done in the back via magic. Also i can come up with 1 million other reason for which the architecture you are trying to use is wrong, but i will leave that for another time.

Improve this answer
Sign up to request clarification or add additional context in comments.

4 Comments

I wanted to create a light framework for my project, but this convinced me. I will be better off learning Codeigniter. There are just so many things, that am doing wrong, not only in this piece of code. However, it was a good learning experience.
Do not underestimate the experience of learning creating or attempting to create your own framework. You should still keep this as a side project. Understanding why the decisions you are taking are wrong is a huge step in understanding larger concepts. I would still go on with this, and see what problems you hit in the future. It will help you alot.
PS: If you want to build a application and want to use a already existing framework, you should consider all your options: Codeigniter, Cake (none of them are my favorites at the moment), symfony 2 (really good framework, based on solid concepts), silex (microframework based on s2 components, excellent for apis/rest interfaces), laravel, zend framework (not my choice, but huge array of components) etc. Asess what are your requirements and choose accordingly :)
I finally settled for Codeigniter, because it has a lot of good documentation and tutorials on the internet. I will not underestimate the learning experience, you are absolutely right. Thank you for your help.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.