php call to undefined function (beginner on classes)

Question

I have 2 files index.php and class_lib.php.

Here is index.php

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
 <head>
    <meta http-equiv="Content-Type" content="text/html;
    charset=iso-8859-1" />
    <title>OOP in PHP</title>
    <?php include("class_lib.php"); ?>
</head>
<body>
        <?php
            $adrian = new person();
            $jimmy = new person;

            $adrian = set_name('adrian de cleir');
            $jimmy = set_name('jimmy darmady');

            echo $adrian->get_name();

    ?>

</body>
</html>

and the file with the class

<?php
    class person {

    var $name;
           function set_name($new_name) {
                      $this->name = $new_name;
                   }
           function get_name() {
                      return $this->name;
                    }



    }
?>

When I load the page I get Fatal error: Call to undefined function set_name() in /var/www/php_learning_testing/index.php on line 15

Thanks for the help, its something silly im sure.

Rudi Visser · Accepted Answer · 2013-01-11 12:20:22Z

6

set_name doesn't exist in the global scope but only off the object, you're doing it right with get_name.

        $adrian = new person();
        $jimmy = new person;

        $adrian->set_name('adrian de cleir');
        $jimmy->set_name('jimmy darmady');

        echo $adrian->get_name();

Your existing code (should set_name actually exist and return a value), would simply overwrite the objects person with the return value of set_name. Whenever you're calling non-static class methods, you always need to reference the instance.

answered Jan 11, 2013 at 12:20

Rudi Visser

22.1k6 gold badges74 silver badges97 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adrian Over a year ago

sorry I dont really follow (just learning OOP for the first time), whats the difference between get_name and set_name in this situation, in terms of the fact that Im doing right with get_name? How do I reference the instance?

Rudi Visser Over a year ago

$adrian-> is the difference, by prefixing it with the object reference ($adrian), you are calling the method within that class :)

phihag · Accepted Answer · 2013-01-11 12:20:06Z

1

In the lines

$adrian = set_name('adrian de cleir');
$jimmy = set_name('jimmy darmady');

you need to call the methods on the objects:

$adrian->set_name('adrian de cleir');
$jimmy->set_name('jimmy darmady');

answered Jan 11, 2013 at 12:20

phihag

289k75 gold badges475 silver badges489 bronze badges

1 Comment

Adrian Over a year ago

Thank you but now I get, Call to a member function get_name() on a non-object in /var/www/php_learning_testing/index.php on line 18 . How is this on a non object?

Boundless · Accepted Answer · 2013-01-11 12:21:36Z

0

for jimmy you have $jimmy = new person; you should have

$jimmy = new person();

then to call a class method you do

$jimmy->set_name('bla');

answered Jan 11, 2013 at 12:21

Boundless

2,4642 gold badges26 silver badges40 bronze badges

Comments

woodle · Accepted Answer · 2013-01-11 12:23:09Z

0

try to set public before the functions. Also replace var in to private. So far I know, var doesn't exist in php ;)

answered Jan 11, 2013 at 12:23

woodle

595 bronze badges

Collectives™ on Stack Overflow

php call to undefined function (beginner on classes)

4 Answers 4

2 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related