Error in this bash script

Question

I want to make a build chain script, and I don't want it to perform until the end if there are error during compilation.

It's the first time I write a more "elaborated" script in bash, and it just doesn't work:

it doesn't echo ERROR although I have lines with the word error in it
whatever the value of testError, the script just hangs in the line

this is the code:

testError=false

output=$(scons)
while read -r line; do
    if [[ $line == .*[eE]rror.* ]] ; then echo 'ERROR' ; $testError = true ; fi #$testError = true fi
done

echo $testError
if  $testError  ; then exit ; fi;

... other commands

EDIT: Following all posters answers and Bash setting a global variable inside a loop and retaining its value -- Or process substituion for dummies and How do I use regular expressions in bash scripts?, this is the final version of the code. It works:

testError=false

shopt -s lastpipe
scons | while read -r line; do
  if [[ $line =~ .*[eE]rror.* ]] ; then
    echo -e 'ERROR' 
    testError=true 
  fi 
  echo -e '.'
done

if  $testError  ; then
    set -e 
fi

chepner · Accepted Answer · 2013-02-14 00:12:46Z

2

You set the value of testError in a subshell induced by your pipeline. When that subshell exits (at the end of the pipeline), any changes you made disappear. Try this:

while read -r line; do
   if [[ $line == .*[eE]rror.* ]] ; then
     echo -e 'ERROR' 
     testError=true 
   fi #$testError = true fi
done < <( scons )

or, if you don't want or can't use process substitution, use a temporary file

scons > tmp
while read -r line; do
  if [[ $line == .*[eE]rror.* ]] ; then
    echo -e 'ERROR' 
    testError=true 
  fi #$testError = true fi
done < tmp

This eliminates the pipeline, so the changes to testError persist after the while loop.

And, if your version of bash is new enough (4.2 or later), there is an option that allows the while loop at the end of a pipeline to execute in the current shell, not a subshell.

shopt -s lastpipe
scons | while read -r line; do
  if [[ $line == .*[eE]rror.* ]] ; then
    echo -e 'ERROR' 
    testError=true 
  fi #$testError = true fi
done

edited Feb 14, 2013 at 0:12

answered Feb 14, 2013 at 0:00

chepner

538k77 gold badges594 silver badges746 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Stephane Rolland Over a year ago

if have version 4.2.24, that might do it.

Gilles Quénot · Accepted Answer · 2013-02-13 23:47:03Z

1

You should try

set -e

this stops the script to continue if a command exit with a non zero status

or better

error_case() { # do something special; }
trap 'echo >&2 "an error occurs"; error_case' ERR

this run error_case function each time a command exit with a non zero status

See http://mywiki.wooledge.org/BashFAQ/105

answered Feb 13, 2013 at 23:47

Gilles Quénot

188k43 gold badges232 silver badges229 bronze badges

Comments

user000001 · Accepted Answer · 2013-02-14 00:04:36Z

1

Another bug is that you have spaces in the assignment. And skip the $

$testError = true

should be

testError=true

EDIT

testerror is changed in the subshell. Try

testerror=$(
    scons | while read -r line; do
        if [[ $line == .*[eE]rror.* ]] ; then
            echo true 
        fi #$testError = true fi
    done
)

edited Feb 14, 2013 at 0:04

answered Feb 13, 2013 at 23:53

user000001

33.8k14 gold badges86 silver badges113 bronze badges

Comments

chepner · Accepted Answer · 2013-02-14 14:11:36Z

1

Are you trying to parse the output of scons?

This:

output=$(scons)
while read -r line; do
    if [[ $line == .*[eE]rror.* ]] ; then 
        echo 'ERROR' 
        testError=true
    fi
done

does not do that. Perhaps you want:

scons | while read -r line; do ... ; done

edited Feb 14, 2013 at 14:11

chepner

538k77 gold badges594 silver badges746 bronze badges

answered Feb 13, 2013 at 23:48

William Pursell

214k49 gold badges279 silver badges317 bronze badges

5 Comments

chepner Over a year ago

The pipeline creates a subshell where changes to testError are no longer global.

Stephane Rolland Over a year ago

@chepner I'm reading this question, related to what you're pointing: stackoverflow.com/questions/9012841/…

William Pursell Over a year ago

@chepner testError does not need to be global; it only needs to be referenced within the loop.

chepner Over a year ago

No, he is explicitly testing the value outside the loop.

William Pursell Over a year ago

@chepner But he should not be! The code can be simplified substantially, and this answer is merely intended to point out his major error: namely that he was not parsing the output of scons.

Community · Accepted Answer · 2017-05-23 10:32:00Z

0

I answer also because other answers didn't notice: the use of regular expression should be done this way, using =~and not ==:

if [[ $line =~ .*[eE]rror.* ]] ; then
...

cf How do I use regular expressions in bash scripts?

edited May 23, 2017 at 10:32

CommunityBot

11 silver badge

answered Feb 14, 2013 at 0:48

Stephane Rolland

40.2k38 gold badges128 silver badges173 bronze badges

Collectives™ on Stack Overflow

Error in this bash script

5 Answers 5

1 Comment

Comments

Comments

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related