Rails: trouble sorting array from view

Question

So I'm trying to let the user sort an array of recipes from a link in my view:

<%= link_to "Score", recipes_sort_path, :order => 'score' %>

I send the parameter "score" to my controller method "sort", which looks like this:

  def sort
    if (params[:order] == 'score')
      @recipes.sort_by(&:score)
    end

    respond_to do |format|
      format.html { redirect_to recipes_path }
      format.json { render json: @recipe }
    end
  end

It redirects to the following index method:

  def index
    # If recipes already present, skip following
    if (!@recipes)
      if (params[:search] || params[:tag])
        @recipes = Recipe.search(params[:search], params[:tag])
      else
        @recipes = Recipe.all
      end
    end

    respond_to do |format|
      format.html 
      format.json { render json: @recipe }
    end
  end

The idea was to be redirected to the index view with the sorted list and just render the view. I get no errors, but when I click the link, the page reloads but nothing happens.

The Recipe class looks like this:

class Recipe < ActiveRecord::Base
  attr_accessible :instructions, :name, :slug, :score, :upvotes, :downvotes, :comments, :image

  has_and_belongs_to_many :ingredients
  has_and_belongs_to_many :tags
  has_many :comments  
  belongs_to :user
  delegate :name, :to => :user, :prefix => :user, :allow_nil => true
  mount_uploader :image, ImageUploader

  validates :name, :presence => true

  def score
    score = (self.upvotes - self.downvotes)
  end
end

What am I doing wrong here?

jvnill · Accepted Answer · 2013-02-22 13:03:30Z

2

There's a third option (the first 2 is from ckruse's answer). You can render the index template from the sort action

def sort
  if (params[:order] == 'score')
    @recipes.sort_by!(&:score)
  end

  respond_to do |format|
    format.html { render :index }
    format.json { render json: @recipe }
  end
end

This will use the index template while using @recipes in the sort action. You also save one request because you're not redirecting.

One more thing I'd like to comment on is the link. It should be

<%= link_to "Score", recipes_sort_path(:order => 'score') %>

UPDATE: fetching @recipes. As much as possible, I want sql to do the sorting so that's what I'm going to do here.

def sort
  @recipes = Recipe

  if params[:order] == 'score'
    @recipes = @recipes.order('upvotes - downvotes')
  end

  respond_to do |format|
    format.html { render :index }
    format.json { render json: @recipe }
  end
end

edited Feb 22, 2013 at 13:03

answered Feb 22, 2013 at 12:49

jvnill

29.6k5 gold badges86 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ckruse Over a year ago

@recipes is still blank in your example.

jvnill Over a year ago

I thought it was clear to you how to get @recipes and sort them by score. You're just having trouble showing a sorted @recipes. Give me a minute to update my answer.

ckruse Over a year ago

I'm afraid it is not clear for the OP. He seems to be new in programming business (sorry :)

Majoren Over a year ago

Yeah, at least new in this framework, thx. I went with your sort method example. It Works, thanks for your time guys.

ckruse · Accepted Answer · 2013-02-22 12:55:23Z

0

First of all: sort_by is not „destructive,” it returns a new array. You may want to use sort_by! or save the return value of sort_by into @recipes.

Second: you do not render anything in your sort action at all. If you posted all code, even @recipes is empty. You can do two things:

Retreive the data in your sort method as you did in your index method and then call render :index
Sort in your index method and do not use a sort method at all. You can route multiple URIs to the same action.

edited Feb 22, 2013 at 12:55

answered Feb 22, 2013 at 12:23

ckruse

9,7701 gold badge27 silver badges25 bronze badges

2 Comments

Majoren Over a year ago

Ok, well I got rid of the sort method, but I'm still doing something wrong. I put the sorting in the index method: ' if (params[:order] == 'score') @recipes.sort! { |r| r.score } end # render view '

ckruse Over a year ago

Do you call your action with the right parameters? E.g. http://localhost:3000/recipes?order=score?

Collectives™ on Stack Overflow

Rails: trouble sorting array from view

2 Answers 2

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related